Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default port in documentation and configs does not match the actual default listen port #1334

Closed
jkhsjdhjs opened this issue May 25, 2021 · 0 comments · Fixed by #1427
Closed

Default port in documentation and configs does not match the actual default listen port #1334

jkhsjdhjs opened this issue May 25, 2021 · 0 comments · Fixed by #1427
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Documentation Improvements or additions to documentation

Comments

@jkhsjdhjs
Copy link

In the configuration file (config.sample.yaml) bindPort: 9999 is commented out by default, which makes it look like the bridge will listen on port 9999 if not specified otherwise. This is not the case, the bridge actually listens on port 8090. This was introduced here: #1274
The linked PR actually intended to change the default port to 8090 in all configurations, scripts and referencing documents, but this was reverted as this port change would break existing setups.

However, I find the current solution confusing as I was wondering quite some time why my homeserver was unable to reach the bridge. That's why I think that at least the sample config should match the actual port.
@tadzik tadzik mentioned this issue Jul 21, 2021
Merged
@jaller94 jaller94 added T-Documentation Improvements or additions to documentation S-Minor Impairs non-critical functionality or suitable workarounds exist labels May 16, 2022
tadzik added a commit that referenced this issue Jul 28, 2022
@tadzik
Merge branch 'develop' into tadzik/gh-1334/default-port-consistency
ad835d1
Half-Shot added a commit that referenced this issue Oct 6, 2022
@Half-Shot
Merge branch 'develop' into tadzik/gh-1334/default-port-consistency
564e8fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Minor Impairs non-critical functionality or suitable workarounds exist T-Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the default port (8090) documented and used consistently matrix-org/matrix-appservice-irc
2 participants
@jkhsjdhjs @jaller94