Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to sync membership from a room we can't access #1373

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Do not attempt to sync membership from a room we can't access #1373

merged 2 commits into from
Jun 8, 2021

Conversation

Half-Shot
Copy link
Contributor

If the bridge cannot join a room, it will repeatedly fail to sync the room and cause the membership sync to fail. We should just ignore these in the membership sync stage.

@Half-Shot Half-Shot requested a review from a team June 7, 2021 15:00
jaller94
jaller94 approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Good to not delay these, if we know that we don't have the permission.

@Half-Shot Half-Shot merged commit 6488006 into develop Jun 8, 2021
@Half-Shot Half-Shot deleted the hs/fix-membership-sync-never-completing branch June 8, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Half-Shot @jaller94