Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to sync membership from a room we can't access #1373

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Do not attempt to sync membership from a room we can't access #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
489e8bb
Do not attempt to sync membership from a room we can't access
Half-Shot Jun 7, 2021
c79dcc8
changelog
Half-Shot Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/1373.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix the bridge never syncing membership if it cannot get the joined users for a room on startup.
4 changes: 4 additions & 0 deletions src/bridge/MemberListSyncer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,10 @@ export class MemberListSyncer {
}
catch (err) {
log.error(`Failed to getJoinedMembers in room ${roomId}: ${err}`);
if (err.data?.errcode === "M_FORBIDDEN") {
// If we're not allowed to, just give up.
return;
}
await Bluebird.delay(3000); // wait a bit before retrying
}
}
Expand Down