Make the default port (8090) documented and used consistently #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadzik
force-pushed
the
tadzik/gh-1334/default-port-consistency
branch
from
530fb46
to
a7c808a
Compare
tadzik
force-pushed
the
tadzik/gh-1334/default-port-consistency
branch
from
a7c808a
to
7169557
Compare
|
I'm all for this, but after a discussion this had previously not been changed to not break bridges for people who didn't configure a port explicitly. |
|
@tadzik It seems like an easy win to make 8090 the default port, sticking with the current default in code. |
Yeah, agreed. It's now 8090 everywhere, so the code is intact but the docs have been updated. |
tadzik
changed the title
Half-Shot
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1334