Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal exception: cli.isDead is not a function #152

Closed
kegsay opened this issue Aug 31, 2016 · 2 comments
Closed

Fatal exception: cli.isDead is not a function #152

kegsay opened this issue Aug 31, 2016 · 2 comments
Assignees

Comments

@kegsay
Copy link
Member

kegsay commented Aug 31, 2016

On https://github.com/matrix-org/matrix-appservice-irc/blob/0.4.0/lib/irc/ClientPool.js#L99

2016-08-31 01:24:28 ERROR:main FATAL EXCEPTION
2016-08-31 01:24:28 ERROR:main TypeError: cli.isDead is not a function
    at ClientPool.getBridgedClientByNick (/home/ircas/matrix-org/freenode/matrix-appservice-irc/lib/irc/ClientPool.js:99:21)
    at createUser (/home/ircas/matrix-org/freenode/matrix-appservice-irc/lib/irc/IrcEventBroker.js:253:24)
    at /home/ircas/matrix-org/freenode/matrix-appservice-irc/lib/irc/IrcEventBroker.js:320:30
    at Array.forEach (native)
    at IrcEventBroker.<anonymous> (/home/ircas/matrix-org/freenode/matrix-appservice-irc/lib/irc/IrcEventBroker.js:317:15)
    at Function.<anonymous> (/home/ircas/matrix-org/freenode/matrix-appservice-irc/lib/irc/IrcEventBroker.js:226:20)
    at Client.<anonymous> (/home/ircas/matrix-org/freenode/matrix-appservice-irc/lib/irc/ConnectionInstance.js:109:12)
    at emitMany (events.js:108:13)
    at Client.emit (events.js:182:7)
    at Client.<anonymous> (/home/ircas/matrix-org/freenode/matrix-appservice-irc/node_modules/irc/lib/irc.js:613:22)
    at emitOne (events.js:82:20)
    at Client.emit (events.js:169:7)
    at iterator (/home/ircas/matrix-org/freenode/matrix-appservice-irc/node_modules/irc/lib/irc.js:836:26)
    at Array.forEach (native)
    at Socket.<anonymous> (/home/ircas/matrix-org/freenode/matrix-appservice-irc/node_modules/irc/lib/irc.js:831:15)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:146:16)
    at Socket.Readable.push (_stream_readable.js:110:10)
    at TCP.onread (net.js:523:20)
$ git status
# On branch v0.4.0
@kegsay kegsay added the bug label Aug 31, 2016
@kegsay kegsay assigned lukebarnard1 and kegsay and unassigned lukebarnard1 Aug 31, 2016
@kegsay
Copy link
Member Author

kegsay commented Aug 31, 2016

Because we're muppets and not using an actual ES6 Map, so default Object builtins are of course not undefined.

kegsay added a commit that referenced this issue Aug 31, 2016
@kegsay
Copy link
Member Author

kegsay commented Aug 31, 2016

Used Object.create(null) instead as ES6 Maps change how you set/get from the map (functions instead) and I don't fancy updating alllll the places. Hotfixed on the matrix.org Freenode bridge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants