Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port specified in config not being used in Docker #1654

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Fix port specified in config not being used in Docker #1654

merged 3 commits into from
Jan 17, 2023

Conversation

justinbot
Copy link
Contributor

@justinbot justinbot commented Jan 9, 2023 •
edited
Loading

Fixes custom port specified in config under homeserver.bindPort not being used in Docker.
The run script for Docker was passing a port which would override this.

Also uses node:16 instead of node:16-slim for the builder container because otherwise on ARM64 architecture it would error when trying to build node-gyp due to missing Python.

@justinbot justinbot requested a review from a team as a code owner January 9, 2023 20:41
@justinbot justinbot self-assigned this Jan 9, 2023
jaller94
jaller94 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@justinbot justinbot merged commit bb915f8 into develop Jan 17, 2023
@justinbot justinbot deleted the justinbot/fix-custom-port branch January 17, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees

@justinbot justinbot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinbot @jaller94