Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port specified in config not being used in Docker #1654

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Fix port specified in config not being used in Docker #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30070ab
Fix specifying port in config
justinbot Jan 9, 2023
5053b37
Add changelog
justinbot Jan 9, 2023
47b0f17
Use full image for builder
justinbot Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ RUN git clone https://github.com/matrix-org/freebindfree.git
RUN cd freebindfree && make

# Typescript build
FROM node:16-slim as builder
FROM node:16 as builder

WORKDIR /build

Expand Down
1 change: 1 addition & 0 deletions changelog.d/1654.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix the configured bind port being overridden in Docker.
2 changes: 1 addition & 1 deletion docker/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ then
ip route add local $PREFIX dev lo
fi

exec node app.js -c /data/config.yaml -p 8090 -f /data/appservice-registration-irc.yaml -u http://localhost:8090
exec node app.js -c /data/config.yaml -f /data/appservice-registration-irc.yaml