Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a generic datastore interface #814

Merged
merged 8 commits into from
Sep 25, 2019
Merged

Create a generic datastore interface #814

merged 8 commits into from
Sep 25, 2019

Conversation

Half-Shot
Copy link
Contributor

This is part of the work required to support PostgreSQL. This PR changes the following:

  • Create an interface which defines the public functions of the existing Datastore.
  • Move NeDBs implementation to it's own datastore, which implements Datastore.
  • Convert dependencies of Datastore (IrcServer/IrcClientConfig) to typescript
  • Split out encrypted password management to a smaller class

@Half-Shot Half-Shot added the Typescript Part of the project to move the codebase to typescript label Sep 18, 2019
@Half-Shot Half-Shot requested a review from a team September 18, 2019 19:52
@Half-Shot Half-Shot mentioned this pull request Sep 18, 2019
Closed
@Half-Shot Half-Shot mentioned this pull request Sep 19, 2019
Merged
benparsons
benparsons approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@benparsons benparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment inline, otherwise lgtm

@Half-Shot Half-Shot removed the request for review from turt2live September 25, 2019 13:12
@Half-Shot Half-Shot merged commit 3704df0 into develop Sep 25, 2019
@jaller94 jaller94 deleted the hs/postgres-models branch March 27, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benparsons benparsons benparsons approved these changes

Assignees
No one assigned
Labels
Typescript Part of the project to move the codebase to typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @benparsons