Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescriptify IrcGenerators and Formatting #832

Merged
merged 6 commits into from
Oct 7, 2019
Merged

Typescriptify IrcGenerators and Formatting #832

merged 6 commits into from
Oct 7, 2019

Conversation

Half-Shot
Copy link
Contributor

Depends on #831

@Half-Shot Half-Shot added the Typescript Part of the project to move the codebase to typescript label Oct 3, 2019
@Half-Shot Half-Shot mentioned this pull request Oct 3, 2019
Merged
@Half-Shot Half-Shot changed the title Convert irc generator and formatter classes to Typescript Typescriptify IrcGenerators and Formatting Oct 3, 2019
benparsons
benparsons approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@benparsons benparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, yes!

@Half-Shot Half-Shot merged commit 033aa74 into develop Oct 7, 2019
@jaller94 jaller94 deleted the hs/ts_irc_generators branch March 27, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benparsons benparsons benparsons approved these changes

Assignees
No one assigned
Labels
Typescript Part of the project to move the codebase to typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @benparsons