Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak counter for leaving users #855

Merged
merged 3 commits into from
Nov 1, 2019
Merged

Tweak counter for leaving users #855

merged 3 commits into from
Nov 1, 2019

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Oct 30, 2019 •
edited
Loading

depends on #845

This change makes it so that we do not queue a leave operation if there are no users to leave. In addition, we no longer count the number of queued promises as the number of leaving users.

@Half-Shot Half-Shot requested a review from a team October 30, 2019 14:26
@Half-Shot Half-Shot mentioned this pull request Oct 30, 2019
Closed
turt2live
turt2live approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some code

src/bridge/MemberListSyncer.ts Show resolved Hide resolved
@Half-Shot Half-Shot changed the base branch from hs/ts_matrixhandler to develop November 1, 2019 16:13
@Half-Shot Half-Shot merged commit 2a95c9b into develop Nov 1, 2019
@jaller94 jaller94 deleted the hs/leave_queue_counter_fix branch March 27, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @turt2live