New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nicer format for Matrix quotes in IRC #1179
Conversation
While this might be an improvement, I've mostly been hearing complaints about how long quotes are with replies. Most irc users seem to be of the opionion that you should reply only with the nick of the person you're replying to, instead of quoting the message. |
I'm in agreement with this one tbh. Could we try it with just the nick: in the form |
I'd go for If you want to keep context and do it time zone independently would be to a format such as But I'd prefer implementing Half-shot's suggestion first and make it nicer later if people complain about the loss of context. |
This won't work: Quotes are used to re-establish context. When leaving out the entire quote, this is no longer being done. I've talked about this with a group of die-hard IRC users (no way to switch to something else, everybody else should just use IRC anyway, and if you have the audacity to not use IRC at least behave like an IRC user), and the consensus was:
This makes sense, but is nothing we can enforce via software. So, what we can do from a technical perspective is offer the far quote format that is acceptable. Not using quotes at all when the message is close is "user education", nothing we can do technically. And I agree that it's even annoying on Matrix if someone quotes the message JUST above their message. Quotes should be used to add context when it has been lost, not to reply to each and every message. Therefore, I think this PR is doing as much as can be done: Fix the format for far quotes to one that is less confusing. The main complaint about the current format is that it was not even immediately clear that this is a quote. The new format mimics how IRC users quote manually: By copying the line from their IRC client. Long term, it seems like IRCv3 is adding support for quotes, but this is currently in draft. |
This addresses one of the most common complaints about using Matrix quotes in IRC channels: That IRC users consider the format of quotes "weird". This commit changes the current format from <user "Original message"> Reply to "<user> Original message" <- Reply which is much more aligned with how IRC users manually quote a message.
I think you might be giving up too easy. We can do near quotes by either by checking if the message being replied to has follow up messages from the same user. This can be done trivially, as the bridge is already bridging messages n the room, so could easily and cheaply cache this information. And as the others suggest, this would make the experience so much better. |
Hello! Chiming in and adding the workarounds we’re discussing with IRC users from the GNOME community: There seem to be several ways to make the experience better The minimalist wayWhen somebody on Matrix makes a reply, completely discard the "quote" part of the reply. That is, if "alex" replies "oh me too!" to "fred" who said "I love pizza!", from IRC the message would look like:
The URL wayWhen somebody on Matrix makes a reply, URLize the "quote" part of the reply. That is, if "alex" replies "oh me too!" to "fred" who said "I love pizza!", from IRC the message would look like:
The URL + beginning of the messageWhen somebody on Matrix makes a reply, URLize the "quote" part of the reply but display the first chars. That is, if "alex" replies "oh me too!" to "fred" who said "I love pizza but I don’t like it when they put too much cheese on it", from IRC the message would look like:
|
As an IRC user, I'd like to request dropping the quote entirely. The "context reestablishing" doesn't work. People would've had to have seen the message being replied to and remember a very short truncated prefix of it to recall it. Most people will only recall the message if it was so recent the quote is entirely redundant. The added burden of parsing these quotes as being quotes and therefore irrelevant is high, many IRC clients don't differentiate any more between messages than they have to so it's basically a solid wall of text, a terminal IRC client in a tmux session on a server is a really popular way of circumventing IRC's lack of channel history for example. Anything between the user's nick and their message makes the association less clear and anything trailing after their message makes it less clear where the next message starts. For those rare occasions when the reference is not clear, simply asking for clarification can often bring everybody up to speed quickly, while many may not be motivated enough to go digging through the backlog. A simple mention is all we need/want (no @'s cause those often trigger bots : ) ) |
I have to srtrongly disagree with that sentiment: The current Discord bridge doesn't do replies at all and entirely drops the context, and the confusion to which it has come already is so, so bad that it's almost better turning down any bridged room. As long as someone can quote a message and expects others to see the same quote, it doesn't work - you can't just silently drop context. It very quickly then comes to the point that there's so much confusion that no briddging is better. This has been proven in the real world to not work already now. |
Discord is not IRC. I think you're making a mistake considering the two even similar. The current situation means bridged matrix users get asked not to use the feature at all, which is probably annoying both in that they need to remember precisely which rooms to refrain from using the feature in and because every time they slip up they get another couple requests to please stop. Bridges should respect the implicit customs of the networks they join. You keep clinging to this idea that the truncated quote provides "context" but that's simply not true. To provide enough context to actually be useful it would have to pretty much repeat the message in its entirety (please don't do this, it would be even worse), of course making it even less readable in the process. |
It doesn't matter if it's IRC, Discord or Matrix - as soon as there is a bridge and there is a reply feature, it will be used. And we've already seen the confusion it causes if context is just silently dropped. Of all the options, silently dropping context is by, far, far, far the worst of all possible options - to the point I would kill the IRC bridge from my rooms if it were actually going that way, because the amount of confusion will just be so much that it kills all discussion. I disagree that the context is useless - the quote is oftentimes complete, and it is only truncated if it does not fit into a single line. This limit should probably be increased a litlle. It also allows scrolling up to the message it was about and reading up the surrounding messages. All of this is gone with just silently dropping quotes. I'd be ok with a way to say "No quotes in this room", but silently dropping it is so bad that it would make the entire IRC bridge useless. tl;dr: A bridge that silently alters meaning of a message is worse than no bridge at all. Please don't go there. |
It does matter whether it's IRC, custom is that the mention is all the context you need. I doubt there would be much confusion past "Oh, you didn't get the message this was replying to?" Certainly not a complete breakdown of communication. I'm fine with the dropping of context not being silent but I imagine a notification every time you use the reply-to feature in a bridged room gets old really quick. |
Ok, let me give you an example why this is a terrible idea, by showing you the same conversation in 4 diferent formats (current, my proposal, your two proposals): Version 1 (current version):
Version 2 (this PR):
Version 3 (drop entirely):
Version 4 (only mention):
You notice why your idea is terrible? I turned around c's statement by 180°, making c say the opposite on IRC than on Matrix. You are now at the point where the bridge is twisting the meaning to say the opposite. This is no worse than having no bridge whatsoever. |
Version 4 is the only one I suggested. And I still prefer it. Afaihs (on IRC channels) that's not how people actually use the reply-to feature. They usually simply always use it. This is the case the UX needs to be optimised for, not the rare exception where it'll cause slight confusion until "c" clarifies their position. |
Except the clarification will never happen, because there is nothing giving away that the bridge just changed the meaning. You cannot fix a social probem (people overusing quotes) with technical means: It just doesn't work, you'll only make it worse. You will not fix it by intentionally breaking it. If I'm a regular user, I would not want to have the bridge silently twist my words to mean the opposite. If I were a user who would know nothing about this and the bridge would have just relayed the opposite of what I said and I would only have found out by pure chance, I would be very upset - and rightfully so. And would probably stop using the IRC bridge or Matrix altogether. Something like that would immediately disqualify any chat product for me and I would never ever touch it again with a ten foot pole. How would you feel if the bridge silently rewrites it when you write "yes" on IRC to be "no" on Matrix? Would you like that? Because you are essentially arguing that this wouldn't be so bad, because you could clarify if it someday gets noticed by pure luck. |
I'm closing my own pull request and deleting it, since this went into a very wrong direction very quickly. I want to avoid making the bridge worse rather than better, and it would be sad if I have to stop using the IRC bridge just because this PR was giving people the idea to entirely break the bridge. Lesson learned: Never create a PR trying to improve things, you'll only give people the idea to make it much worse. |
“Meanwhile, the poor Babel fish, by effectively removing all barriers to communication between different races and cultures, has caused more and bloodier wars than anything else in the history of creation.” |
I don't understand why a couple of my comments necessitate completely abandoning the work. Any improvement would be welcome. As an IRC user I've just observed numerous complaints about this and when it came up yet again yesterday someone pointed out nothing would be improved unless people voiced their opinion. I had remained quiet until now because I figured the bridge maintainers must already be away of what a painpoint this is for IRC users and I wanted to avoid drama. Re misunderstandings, it's hardly as if most interactions via chat are binary along the lines of yes/no, it really seems like an exaggeration to say that reducing reply-to to a mention would cause more than a limited amount of confusion, once this has happened once the matrix user would be somewhat aware of avoiding it in the future. Which, IMO, would still be better than having to retrain behavior so you don't use reply-to in rooms bridged to IRC. If the maintainers prefer OP's suggestions, I'm sure my comments wouldn't keep them from merging the PR as-is. Though @thibaultamartin's suggestion to make the quote a suffix rather than a prefix reads a lot clearer to me. It was really not my intent to have this PR closed without review. I'm sorry if my opinions aren't welcome here, I'll refrain from sharing them. |
I'd rather maintain the status quo than making it even more confusing, hence I closed the PR since this was moving into the opposite direction of what I wanted to achieve. |
This addresses one of the most common complaints about using Matrix
quotes in IRC channels: That IRC users consider the format of quotes
"weird".
This commit changes the current format from
to
which is much more aligned with how IRC users manually quote a message.