Add a few more sensible tests to the connection pools #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
hs/add-pooling-test
branch
from
44a3f9a
to
995bce1
Compare
AndrewFerr
reviewed
Jun 1, 2023
AndrewFerr
reviewed
Jun 1, 2023
AndrewFerr
requested changes
Jun 1, 2023
AndrewFerr
approved these changes
Jun 2, 2023
Half-Shot
added a commit
that referenced
this pull request
Jun 9, 2023
* Get restart tests going * Add tests to ensure we can cope with invalid legacy state * Add a note * Don't skip * Drop bluebird stuff * Oppertunistically discover channels that may be missing * Fix supported state being horribly bloaty * Forcibly delete bridge state when creating a new connection * Fix channel discovery * Update node-irc package * Drop unused * changelog * Add a check * Applying reccomendations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a bug in our RedisState