Refactor the command parser #1756

Half-Shot · 2023-07-27T15:47:37Z

We wrote a command parser twice, and it's about time we reconciled it a bit.

src/bridge/AdminRoomHandler.ts

src/provisioning/Provisioner.ts

src/models/IrcRoom.ts

Half-Shot added 6 commits July 27, 2023 15:01

Port all IRC bridge command handling to a common function

a6c9901

Add tests for new command parser

a19f9d1

Validate channel name

f53aeee

Drop the focus test

86ad404

Tidy up response format

0684e47

changelog

fbf06a0

Half-Shot requested a review from a team as a code owner July 27, 2023 15:47

progval reviewed Jul 27, 2023

View reviewed changes

src/bridge/AdminRoomHandler.ts Outdated Show resolved Hide resolved

Half-Shot added 2 commits July 27, 2023 16:57

Clean up my mistakes

8931eb0

appease linter gods

25a13d8

AndrewFerr reviewed Jul 27, 2023

View reviewed changes

src/bridge/AdminRoomHandler.ts Show resolved Hide resolved

src/provisioning/Provisioner.ts Outdated Show resolved Hide resolved

Half-Shot added 2 commits July 27, 2023 17:10

Disallow just prefix

3b487c7

A space

df806b1

AndrewFerr approved these changes Jul 27, 2023

View reviewed changes

progval reviewed Jul 27, 2023

View reviewed changes

src/models/IrcRoom.ts Outdated Show resolved Hide resolved

Handle nulls

69f949d

Half-Shot merged commit 11f0d07 into develop Jul 27, 2023
15 checks passed

Half-Shot deleted the hs/refactor-command-parser branch July 27, 2023 17:46

Provide feedback