Add tests for various forms of rich replies #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadzik
force-pushed
the
tadzik/replies-tests
branch
2 times, most recently
from
391d19c
to
f1267ba
Compare
Signed-off-by: Tadeusz „tadzik” Sośnierz <tadeusz@sosnierz.com>
tadzik
force-pushed
the
tadzik/replies-tests
branch
from
f1267ba
to
19bf636
Compare
Half-Shot
approved these changes
Mar 21, 2024
src/bridge/MatrixHandler.ts
Outdated
| @@ -386,6 +393,9 @@ export class MatrixHandler { | |||
| * @param {Object} event : The Matrix member event. | |||
| */ | |||
| private _onMemberEvent(req: BridgeRequest, event: OnMemberEventData) { | |||
| if (event.origin_server_ts) { | |||
There was a problem hiding this comment.
This is only joins, right?
There was a problem hiding this comment.
Ooh, should be, yes.
There was a problem hiding this comment.
Ah, also we need to bound these by leave time too. Or maybe just delete the map entry, given you won't be replying to anything after you've left.
There was a problem hiding this comment.
Interestingly, it still works in this state, since your subsequent join will reset the map entry –so you won't be able to see messages from before your most recent join.
Still, I'd rather be explicit and have a test for it than rely on this quirk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up and expanded #1797