Metrics for MatrixHandler - Iline Kicks #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Aug 10, 2018
turt2live
requested changes
Aug 10, 2018
lib/bridge/IrcBridge.js
Outdated
|
|
||
| matrixHandlerConnFailureKicks.set( | ||
| {server: server.domain}, | ||
| mxMetrics["connection_failure_kicks"] ? mxMetrics["connection_failure_kicks"] : 0 |
There was a problem hiding this comment.
mxMetrics["connection_failure_kicks"] || 0 also works
lib/bridge/MatrixHandler.js
Outdated
| let metricSet = this.metrics[serverDomain]; | ||
| if (metricSet === undefined) { | ||
| metricSet = this.metrics[serverDomain] = { | ||
|
|
There was a problem hiding this comment.
the linter isn't actually forcing you to have this empty line, is it?
lib/bridge/MatrixHandler.js
Outdated
| @@ -1481,6 +1485,22 @@ MatrixHandler.prototype._onUserQuery = Promise.coroutine(function*(req, userId) | |||
| yield this.ircBridge.getMatrixUser(ircUser); | |||
| }); | |||
|
|
|||
| MatrixHandler.prototype._incrementMetric = function(serverDomain, metricName) { | |||
| let metricSet = this.metrics[serverDomain]; | |||
| if (metricSet === undefined) { | |||
There was a problem hiding this comment.
actually can we just have this be a !metricSet?
lib/bridge/IrcBridge.js
Outdated
| metrics.addCollector(() => { | ||
| this.ircServers.forEach((server) => { | ||
| reconnQueue.set({server: server.domain}, | ||
| this._clientPool.totalReconnectsWaiting(server.domain) | ||
| ); | ||
| let mxMetrics = this.matrixHandler.getMetrics(server.domain); | ||
| if (mxMetrics === null) { | ||
| mxMetrics = {} |
lib/bridge/MatrixHandler.js
Outdated
| @@ -1515,6 +1535,13 @@ MatrixHandler.prototype.onUserQuery = function(req, userId) { | |||
| return reqHandler(req, this._onUserQuery(req, userId)) | |||
| }; | |||
|
|
|||
| MatrixHandler.prototype.getMetrics = function(serverDomain) { | |||
| if (this.metrics[serverDomain] === undefined) { | |||
There was a problem hiding this comment.
This if statement isn't guarding anything
turt2live
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us determine the damage when we kick lots of people for failing to get a client.