Release v0.11.2 #698
Merged
Release v0.11.2 #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valodim
reviewed
Oct 5, 2018
config.sample.yaml
Outdated
| # This is used to stem the flow of requests in case of a mass quit/leave, which might | ||
| # slow down the homeserver. | ||
| leaveConcurrency: 10 |
There was a problem hiding this comment.
Good catch, this is a develop feature atm.
| @@ -1,6 +1,11 @@ | |||
| "$schema": "http://json-schema.org/draft-04/schema#" | |||
| type: "object" | |||
| properties: | |||
| advanced: | |||
There was a problem hiding this comment.
what about ircHandler->leaveConcurrency?
| if (bridgedClient.isDead()) { | ||
| return; // We don't want to include dead ones. | ||
| if (!bridgedClient || bridgedClient.isDead()) { | ||
| // We don't want to include dead ones, or ones that don't exist. |
There was a problem hiding this comment.
var isNonexistentOrDead = !bridgedClient || bridgedClient.isDead()
if (isNonexistentOrDead) {
same amount of lines, expresses semantics in code instead of comments
There was a problem hiding this comment.
Good point, I'll include this in the next release since it's non-critical (and saves us having to apply it to two branches) but definitely reads better.
Should be fixed by the null checking, so I'll add a statement to that effect in the changelogs. |
|
That didn't actually end up in the changelog now, did it? |
|
Oops, my bad. Sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.