Add support for proxy to connect to the Slack API #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
approved these changes
Apr 26, 2023
| @@ -0,0 +1 @@ | |||
| Add support for proxy to connect to the Slack API. | |||
There was a problem hiding this comment.
Suggested change
| Add support for proxy to connect to the Slack API. | |
| Add support for specifying a HTTP proxy to connect to the Slack API. |
Slightly more colour :)
|
Contrib requirement is broken because our regex is doing the wrong things (matrix-org/backend-meta#20). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for this project!
I am using this bridge in an environment that requires me to use a proxy to connect to the Slack API, therefore I needed to add the feature.
Credit to #338 for starting the work.
Signed off by: Gaël Berthaud-Müller gael+github@berthaud-muller.eu