Make sign-off regex more leniant #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the sign off checker to stop assuming everyone's name is matched by `[\w ]+`. (*cough* https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/ *cough*). Instead, we're just going to check for the absence of whitespace and assume that reviewers will do a visual test to make sure the name *looks* okay. Also dropping the requirement for < and > to wrap the email, as not everyone does it and I don't think it's a hard requirement.
|
(Released in v2.0.3, and I moved the v2 tag forward accordingly.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the sign off checker to stop assuming everyone's name is matched by
[\w ]+. (cough https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/ cough).Instead, we're just going to check for the absence of whitespace and assume that reviewers will do a visual test to make sure the name looks okay.
Also dropping the requirement for < and > to wrap the email, as not everyone does it and I don't think it's a hard requirement.