Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack integration with matrix is posting double messages #788

Open
gabrielaprad0 opened this issue Jun 13, 2024 · 4 comments · May be fixed by #790
Open

Slack integration with matrix is posting double messages #788

gabrielaprad0 opened this issue Jun 13, 2024 · 4 comments · May be fixed by #790

Comments

@gabrielaprad0
Copy link

the integration Slack with Element is posting double messages, here is link to the matrix channel
https://app.element.io/#/room/#ic-node-providers:matrix.org
Could you please, help with it?

image
@sasa-tomic
Copy link

Possibly related to
#498
#486
#481
#482
#316

@Half-Shot I've seen that you have been involved in many of the above threads. Any suggestion on how to proceed? This problem has been plaguing us for months now, it's super annoying.

@sasa-tomic
Copy link

#782 could possibly also be related. @tadzik WDYT? Also, any ETA on when #782 could land?

@sasa-tomic
Copy link

Any update here @Half-Shot @tadzik ?

@tadzik
Copy link
Contributor

tadzik commented Jul 4, 2024

Not related to #782, I'd assume a puppeting problem similar to #481. Will look into this further.

tadzik added a commit that referenced this issue Jul 4, 2024
@tadzik
Push Matrix->Slack messages through the same queue as Slack->Matrix
8ccd84d 
There is a possible race condition when a message gets sent from Matrix to Slack,
and its echo arrives from Slack to Matrix before we got the response from Slack.
We'd then check for its presence in recentSlackMessages before it actually gets added there,
resulting in an undesirable echo and duplicate messages.

This adds Matrix->Slack sends to the same FIFO queue as we do for Slack->Matrix,
which ensures that we would have added a message to recentSlackMessages before we start processing its echo.

Hopefully fixes GH-788.
@tadzik tadzik linked a pull request Jul 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tadzik @sasa-tomic @gabrielaprad0