Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session detail page #1658

Merged
merged 6 commits into from
Aug 31, 2023
Merged

Session detail page #1658

merged 6 commits into from
Aug 31, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Aug 31, 2023

For #1550

Screenshot 2023-08-31 at 16 12 13 Screenshot 2023-08-31 at 16 27 21
  • Renames browser session route from /sessions -> browser-sessions, /session -> browser-session
  • Add session detail route /session/<deviceId>
  • Get session and display using session tile

In next PRs:

  • linking from session lists to detail
  • handling route params to redirect to detail
  • ? more detail on detail page

@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 31, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: de5b388
Status: ✅  Deploy successful!
Preview URL: https://13df677a.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://kerry-1550-session-page.matrix-authentication-service-docs.pages.dev

View logs

Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@sandhose sandhose merged commit fc1e5b9 into main Aug 31, 2023
21 of 23 checks passed
@sandhose sandhose deleted the kerry/1550/session-page branch October 23, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants