Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information to session detail page #1659

Merged
merged 10 commits into from
Aug 31, 2023

Conversation

kerryarchibald
Copy link
Contributor

For #1550

Compatibility session:
Screenshot 2023-08-31 at 17 44 01
Oauth2 session:
Screenshot 2023-08-31 at 17 30 39

  • adds link from session tile title to detail page
  • adds details to detail page

In next PRs:

  • handling route params to redirect to detail

@kerryarchibald kerryarchibald added the T-Enhancement New feature of request label Aug 31, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 31, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8d44bdc
Status: ✅  Deploy successful!
Preview URL: https://950132e3.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://kerry-1550-session-detail-mo.matrix-authentication-service-docs.pages.dev

View logs

@kerryarchibald kerryarchibald changed the base branch from kerry/1550/session-page to main August 31, 2023 09:31
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the infos that are shown here (@pmaier1 @Johennes?), but on the code side LGTM

Also now EX are giving a proper logo_uri, so it would be nice to display that one :)

@Johennes
Copy link

The displayed fields look like a good start to me. So given that we have only one day left before the deadline, I wouldn't block this pull request on it. If needed, we can follow up afterwards.

If the logo would be trivial to include, agree that it would be a pretty fancy addition. 🙂

@kerryarchibald
Copy link
Contributor Author

Made a ticket for logo, will work on it after the redirect if I have time #1672

@kerryarchibald kerryarchibald enabled auto-merge (squash) August 31, 2023 21:54
@kerryarchibald kerryarchibald merged commit 0c267c0 into main Aug 31, 2023
21 of 23 checks passed
@pmaier1
Copy link
Collaborator

pmaier1 commented Sep 1, 2023

Looks good for now, thanks. Some fields are certainly a bit technical and need design review but we can do that in a later release.

@sandhose sandhose deleted the kerry/1550/session-detail-more-detail branch October 23, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New feature of request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants