Implement MSC2965 action parameter #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
reviewed
Sep 1, 2023
frontend/src/Router.tsx
Outdated
|
|
||
| const [route, setRoute] = useAtom(routeAtom); | ||
| if (redirect) { | ||
| setRoute(redirect.route, redirect.searchParams); |
There was a problem hiding this comment.
I think this should be in a useEffect, because you're not supposed to do state changes in the render?
There was a problem hiding this comment.
Kerry won't see this before Monday, sadly, and we have to land this PR today. @t3chguy could you help us out by giving advice?
There was a problem hiding this comment.
I can take care of finishing that up, alongside the server side of this
There was a problem hiding this comment.
Yes I believe it should be in a useEffect
Deploying with
|
| Latest commit: |
651d948
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e670dbd.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://kerry-1550-logout-deep-link.matrix-authentication-service-docs.pages.dev |
|
Alright, I:
|
sandhose
changed the title
sandhose
force-pushed
the
kerry/1550/logout-deep-link
branch
from
ec61b6e
to
651d948
Compare
germain-gg
pushed a commit
to element-hq/compound-web
that referenced
this pull request
Sep 28, 2023
Ported from MAS, thank you @sandhose See matrix-org/matrix-authentication-service#1673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1550
Redirects to session detail when query param
action=session_endis encountered.Screen.Recording.2023-09-01.at.14.48.35.mov