Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid JID in disco#items #199

Open
Zash opened this issue Nov 11, 2020 · 0 comments
Open

Invalid JID in disco#items #199

Zash opened this issue Nov 11, 2020 · 0 comments
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@Zash
Copy link

Zash commented Nov 11, 2020

Service discovery listing on xmpp:matrix.org lists a room with a JID containing two @ signs. According to the RFC on XMPP Addresses, this is not valid, as explicitly stated in §3.3.1.

If Matrix allows @ signs in localparts then these will need to be escaped, e.g. using XEP-0106.

To reproduce

Send:
<iq to='matrix.org' type='get' id='9b922d3a-251c-4edb-b1ca-d27793126866' xml:lang='en'>
  <query xmlns='http://jabber.org/protocol/disco#items'/>
</iq>

Receive:
<iq from='matrix.org' type='result' id='9b922d3a-251c-4edb-b1ca-d27793126866' xml:lang='en'>
  <query xmlns='http://jabber.org/protocol/disco#items'>
    <item jid='#_twitter_@lvv2com#matrix.org@matrix.org' name='[Twitter] 今日热点'/>
    <!-- other items removed for brevity -->
  </query>
</iq>
@jaller94 jaller94 added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Development

No branches or pull requests

2 participants