Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In AS API, PUT /transactions/* endpoint, document how to distinguish state event from timeline event #1014

Closed
uhoreg opened this issue Oct 10, 2017 · 3 comments
Closed

In AS API, PUT /transactions/* endpoint, document how to distinguish state event from timeline event #1014

uhoreg opened this issue Oct 10, 2017 · 3 comments
Assignees
@turt2live
Labels
application services clarification An area where the spec could do with being more explicit
Projects
August 2018 r0

Comments

@uhoreg
Copy link
Member

uhoreg commented Oct 10, 2017 •
edited
Loading

as indicated in matrix-org/matrix-react-sdk#1453 and element-hq/element-web#5176, a user can send an event that has a type that matches a state event (e.g. m.room.topic) as a timeline event. Obviously, this won't change the room's state, but since PUT /transactions/* doesn't indicate whether the event was sent as a state event or a timeline event, it could result in a confused AS if this happens, as the AS may think that the state has changed when it actually hasn't.
@richvdh
Copy link
Member

richvdh commented Oct 13, 2017

It should be possible to distinguish a state event by the presence of a state_key field?

@uhoreg
Copy link
Member Author

uhoreg commented Oct 14, 2017

It should be possible to distinguish a state event by the presence of a state_key field?

Yeah, I guess that works. Maybe that could be documented somewhere.

@uhoreg uhoreg changed the title In AS API, PUT /transactions/* endpoint doesn't specify if the event was sent as a state event In AS API, PUT /transactions/* endpoint, document how to distinguish state event from timeline event Oct 14, 2017
@richvdh
Copy link
Member

richvdh commented Oct 15, 2017

Yeah. It's in https://matrix.org/speculator/spec/HEAD/client_server/unstable.html#state-event-fields ("The presence of this key makes this event a State Event"), but I very much agree it's impossible to find there.

@richvdh richvdh added the clarification An area where the spec could do with being more explicit label Oct 15, 2017
@turt2live turt2live added this to To do: appservices (prioritized) in August 2018 r0 Aug 14, 2018
@turt2live turt2live self-assigned this Aug 17, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 17, 2018
@turt2live
Explicitly say how appservices should detect state events
5b5b4cf 
Fixes matrix-org#1014
@turt2live turt2live mentioned this issue Aug 17, 2018
Merged
@turt2live turt2live moved this from To do: appservices (prioritized) to In review in August 2018 r0 Aug 17, 2018
August 2018 r0 automation moved this from In review to Done (this list will be incomplete) Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
application services clarification An area where the spec could do with being more explicit
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@uhoreg @turt2live @richvdh