Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Only allow event state event handlers on state events #1453

Merged
merged 3 commits into from
Oct 11, 2017

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 6, 2017

and vice versa so you cannot get people sending m.room.topic as a non-state event and make Riot render X changed the room topic to Y as they do not have permission to do so.

thanks to nepugia (@lowee:matrix.org) for bringing this to my attention :)

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy added a commit to matrix-org/matrix-static that referenced this pull request Oct 6, 2017
to prevent misfiring the handlers leading to fun...
Same as matrix-org/matrix-react-sdk#1453

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@uhoreg
Copy link
Member

uhoreg commented Oct 10, 2017

fixes element-hq/element-web#5176

@lukebarnard1
Copy link
Contributor

LGTM!

@lukebarnard1 lukebarnard1 merged commit 8aee5e1 into develop Oct 11, 2017
@t3chguy t3chguy deleted the t3chguy/textForEvent branch October 29, 2017 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants