Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default push rules that aren't specced #1163

Closed
3 tasks done
turt2live opened this issue Mar 18, 2018 · 0 comments
Closed
3 tasks done

Default push rules that aren't specced #1163

turt2live opened this issue Mar 18, 2018 · 0 comments
Assignees
@turt2live
Labels
spec-omission implemented but not currently specified
Projects
August 2018 r0

Comments

@turt2live
Copy link
Member

turt2live commented Mar 18, 2018 •
edited

@turt2live turt2live added the spec-omission implemented but not currently specified label Jul 19, 2018
@turt2live turt2live added this to To do: client-server (prioritized) in August 2018 r0 Aug 14, 2018
@turt2live turt2live mentioned this issue Aug 14, 2018
Closed
4 tasks
@turt2live turt2live self-assigned this Aug 22, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 22, 2018
@turt2live
General improvements to the push rules module
7ec3cc4 
This commit does a few things:
* Add 3 undocumented push rules to the spec for encrypted events and at-room notifications.
* Require unrecognized conditions to not match, ensuring that future conditions do not cause clients to accidentally notify users.
* Clarify that push rules should be enabled when created.
* Document a new condition required for at-room notifications.

Fixes matrix-org#1163
Fixes matrix-org#1034
Fixes matrix-org#676
Fixes matrix-org#1033
Relates to matrix-org#1101
@turt2live turt2live mentioned this issue Aug 22, 2018
Merged
@turt2live turt2live moved this from To do: client-server (prioritized) to In review in August 2018 r0 Aug 22, 2018
@turt2live turt2live moved this from In review to In review (just the issues) in August 2018 r0 Aug 24, 2018
August 2018 r0 automation moved this from In review (just the issues) to Done (this list will be incomplete) Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
spec-omission implemented but not currently specified
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live