Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing m.room.aliases with an m.room.alias event listing a single alias #532

Closed
richvdh opened this issue Aug 29, 2019 · 5 comments
Labels
A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol

Comments

@richvdh
Copy link
Member

richvdh commented Aug 29, 2019

Currently, the m.room.aliases state event has a state_key corresponding to a given server name, and it lists all the aliases for a given room on that server (or at least, it is intended to). This runs the risk of races when making several changes to the directory at once.

Instead, we could have an m.room.alias event for each alias. For example:

{
    "sender": "@user:foo.com",
    "type": "m.room.alias",
    "state_key": "#sommeliers:foo.com",
    "content": {}
}

(This was originally proposed in matrix-org/matrix-spec-proposals#1130, but I have split it to here to remove redundant content.)

@turt2live turt2live added A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol labels Aug 29, 2019
@richvdh
Copy link
Member Author

richvdh commented Aug 30, 2019

As pointed out on matrix-org/matrix-spec-proposals#1130: one problem with this is that currently, the matrix protocol doesn't support deleting state (#456). We could instead set an inactive flag in the content, but it would lead to proliferation of redundant state events.

@ara4n
Copy link
Member

ara4n commented Aug 30, 2019

the whole inactive: true bodge seems okay until we finally support deleting state

@richvdh
Copy link
Member Author

richvdh commented Sep 3, 2019

we should also take the opportunity to harden up the validation rules to solve things like https://github.com/matrix-org/matrix-doc/issues/2277.

@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@KitsuneRal
Copy link
Member

m.room.aliases is no more a thing, and we took a different route about the whole thing instead of introducing m.room.alias. Should this be closed-as-not-planned?

@richvdh
Copy link
Member Author

richvdh commented Jan 2, 2024

Indeed. MSC2432 removed the special meaning for m.room.aliases.

@richvdh richvdh closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client-Server Issues affecting the CS API enhancement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
Development

No branches or pull requests

4 participants