Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial version of spec for key backups #2387

Merged
merged 19 commits into from Jun 2, 2020

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Dec 16, 2019

Spec PR for #1219 / #1538 and #2526.

Does not have any mentions of SSSS or cross-signing keys, since those parts are not written up yet.

Rendered version of changes at https://12751-24998719-gh.circle-artifacts.com/0/scripts/gen/client_server/unstable.html#server-side-key-backups

Co-Authored-By: Matthew Hodgson <matthew@arasphere.net>
@ara4n
Copy link
Member

ara4n commented Jan 7, 2020

lgtm from medium-to-high level review :)

uhoreg and others added 3 commits February 7, 2020 15:28
Co-Authored-By: Matthew Hodgson <matthew@arasphere.net>
also copy description of forwarding_curve25519_key_chain from key exports, since
it's a better description
@uhoreg uhoreg requested a review from a team March 20, 2020 21:00
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine and is definitely understandable - thank you! I mostly have stylistic concerns here (full stops at end of sentences, error responses, indentation, etc).

@@ -0,0 +1,50 @@
# Copyright 2019 The Matrix.org Foundation C.I.C.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 that this has been stuck in the queue this long

api/client-server/key_backup.yaml Outdated Show resolved Hide resolved
api/client-server/key_backup.yaml Outdated Show resolved Hide resolved
api/client-server/key_backup.yaml Show resolved Hide resolved
api/client-server/key_backup.yaml Show resolved Hide resolved
api/client-server/key_backup.yaml Outdated Show resolved Hide resolved
api/client-server/key_backup.yaml Outdated Show resolved Hide resolved
api/client-server/key_backup.yaml Outdated Show resolved Hide resolved
api/client-server/key_backup.yaml Outdated Show resolved Hide resolved
specification/modules/end_to_end_encryption.rst Outdated Show resolved Hide resolved
@uhoreg
Copy link
Member Author

uhoreg commented May 6, 2020

Waiting for #2526, and I still need to check error codes.

@uhoreg uhoreg requested a review from turt2live May 8, 2020 20:55
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks sane. I haven't verified accuracy to the proposals in this review, but the explanations look sensible.

I might come by at a later point and review accuracy when time is more available.

Edit: LGTM modulo comments below.

specification/modules/end_to_end_encryption.rst Outdated Show resolved Hide resolved
api/client-server/key_backup.yaml Outdated Show resolved Hide resolved
specification/modules/end_to_end_encryption.rst Outdated Show resolved Hide resolved
api/client-server/key_backup.yaml Show resolved Hide resolved
uhoreg and others added 2 commits June 1, 2020 22:34
Co-authored-by: Travis Ralston <travpc@gmail.com>
@uhoreg uhoreg merged commit cf37688 into matrix-org:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants