-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial version of spec for key backups #2387
Merged
Merged
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e658b17
initial version of spec for key backups
uhoreg 59e3371
remove duplicated line
uhoreg 4cde800
fix validation errors
uhoreg 90bf2b3
add changelog
uhoreg a62c817
Apply suggestions from code review
uhoreg 41072fc
Apply suggestions from code review
uhoreg e67ba0c
add note indicating similarity between key backup format and key exports
uhoreg 30586ed
remove extra space
uhoreg e0b4a3c
Apply suggestions from code review
uhoreg 8ff1c26
fix indentation
uhoreg 5f3ee44
add more suggestions from review
uhoreg 3d1c33e
move API definitions into backup section
uhoreg 0145191
add links to endpoints and add delete endpoint
uhoreg a896729
some more clarifications and indentation fixes
uhoreg 1bae8ea
we actually don't support the GET /room_key/versions/ with trailing s…
uhoreg bd95568
remove duplicate key
uhoreg fae1165
spec what to do if you try to delete a backup that's already deleted
uhoreg 40c50c8
Apply suggestions from code review
uhoreg a362848
more clarifications and fixes
uhoreg File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# Copyright 2019 The Matrix.org Foundation C.I.C. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
type: object | ||
title: KeyBackupData | ||
description: "The key data" | ||
properties: | ||
first_message_index: | ||
description: |- | ||
The index of the first message in the session that the key can decrypt. | ||
type: integer | ||
example: 1 | ||
forwarded_count: | ||
description: |- | ||
The number of times this key has been forwarded via key-sharing between devices. | ||
type: integer | ||
example: 0 | ||
is_verified: | ||
description: |- | ||
Whether the device backing up the key verified the device that the key | ||
is from. | ||
type: boolean | ||
example: false | ||
session_data: | ||
description: |- | ||
Algorithm-dependent data. See the documentation for the backup | ||
algorithms in `Server-side key backups`_ for more information on the | ||
expected format of the data. | ||
type: object | ||
example: { | ||
"ephemeral": "base64+ephemeral+key", | ||
"ciphertext": "base64+ciphertext+of+JSON+data", | ||
"mac": "base64+mac+of+ciphertext" | ||
} | ||
required: | ||
- first_message_index | ||
- forwarded_count | ||
- is_verified | ||
- session_data |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 that this has been stuck in the queue this long