Clarify why a specific hostname is expected in the server certificate #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested changes
Aug 9, 2021
There was a problem hiding this comment.
Thanks for the contribution! I've made some suggestions for clarification/accuracy below.
@turt2live: I'm afraid I'm unclear as to whether minor background information points like this need a changelog entry. WDYT?
|
Any change to the rendered spec needs a changelog entry. At a glance, this would be a clarification. |
|
(we also need sign-off per the contributing guidelines. Easiest way is to leave a |
|
Signed-off-by: Niels Basjes niels@basjes.nl |
… than `<delegated_hostname>` for SRV delegation. Signed-off-by: Niels Basjes <niels@basjes.nl>
nielsbasjes
force-pushed
the
ClarifyTLS
branch
from
531c896
to
cafa603
Compare
richvdh
pushed a commit
that referenced
this pull request
Aug 23, 2021
… than `<delegated_hostname>` for SRV delegation. (#3322) Signed-off-by: Niels Basjes <niels@basjes.nl>
richvdh
pushed a commit
that referenced
this pull request
Aug 27, 2021
… than `<delegated_hostname>` for SRV delegation. (#3322) Signed-off-by: Niels Basjes <niels@basjes.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposed clarification for
#3321