Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add m.login.appservice to the spec #3324

Merged
merged 9 commits into from
Dec 28, 2021
Merged

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Aug 9, 2021

@Half-Shot Half-Shot requested a review from a team August 9, 2021 21:53
@turt2live turt2live added this to Awaiting initial idea feedback in Spec Core Team Backlog via automation Aug 9, 2021
@turt2live turt2live moved this from Awaiting initial idea feedback to Requires spec review (post-FCP) in Spec Core Team Backlog Aug 9, 2021
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've put all this in the wrong section. MSC2778 doesn't specify a UIA authentication type, but rather a modification to the /login endpoint (which doesn't use UIA). It should be in this section: https://spec.matrix.org/unstable/client-server-api/#login.

@Half-Shot Half-Shot requested a review from richvdh August 16, 2021 08:26
@Half-Shot
Copy link
Contributor Author

Sorry, my mistake. I homed in on the thing that looked like login types without thinking.

I've moved and reworked the section to hopefully make it fit better with /login.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks better now. A few nits.

Would it be helpful to add a link from the appservice spec?

content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
changelogs/client_server/newsfragments/3324.feature Outdated Show resolved Hide resolved
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@Half-Shot Half-Shot self-assigned this Aug 17, 2021
@richvdh richvdh removed this from Requires spec review (post-FCP) in Spec Core Team Backlog Sep 7, 2021
@turt2live
Copy link
Member

@Half-Shot do you have bandwidth to update this?

@Half-Shot
Copy link
Contributor Author

My bandwidth is in the negatives atm

@turt2live
Copy link
Member

Would you be opposed to this being taken over to get it over the line?

@turt2live turt2live assigned turt2live and unassigned Half-Shot Nov 5, 2021
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@uhoreg uhoreg requested review from a team and removed request for a team December 28, 2021 20:13
@uhoreg uhoreg requested a review from a team December 28, 2021 20:45
@turt2live turt2live removed their assignment Dec 28, 2021
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm - thanks!

content/client-server-api/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Travis Ralston <travisr@matrix.org>
@uhoreg uhoreg merged commit acf44d7 into old_master Dec 28, 2021
turt2live added a commit that referenced this pull request Dec 28, 2021
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
Co-authored-by: Travis Ralston <travisr@matrix.org>
HarHarLinks added a commit to HarHarLinks/matrix-spec that referenced this pull request Dec 19, 2022
turt2live pushed a commit to matrix-org/matrix-spec that referenced this pull request Dec 19, 2022
* move login API definitions to the right heading

regressed from matrix-org/matrix-spec-proposals#3324

* Create 1382.clarification
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
* move login API definitions to the right heading

regressed from matrix-org/matrix-spec-proposals#3324

* Create 1382.clarification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants