Move prev_content to unsigned
#3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per MSC3442, `prev_content` should be under unsigned.
richvdh
force-pushed
the
rav/move_prev_content
branch
from
6e0102b
to
47d4ce9
Compare
turt2live
requested changes
Nov 23, 2021
Co-authored-by: Travis Ralston <travisr@matrix.org>
... rather than magic for "this version"
turt2live
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per MSC3442,
prev_contentshould be under unsigned.I wanted to document its history properly, so ended up adding some magic to the openapi-table-renderer to do so. I think we should probably use this to replace the existing
x-addedInMatrixVersionannotations, but have left this for a future PR.fixes: #877
Preview: https://pr3524--matrix-org-previews.netlify.app