Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to incorporate MSC3173 (stripped state for all) into the spec? #3413

Closed
turt2live opened this issue Sep 24, 2021 · 4 comments · Fixed by #3606
Closed

How to incorporate MSC3173 (stripped state for all) into the spec? #3413

turt2live opened this issue Sep 24, 2021 · 4 comments · Fixed by #3606
Assignees
Labels
client-server Client-Server API meta Something that is not a spec change/request and is not related to the build tools

Comments

@turt2live
Copy link
Member

MSC3173

This MSC is a bit awkward because it doesn't make any behavioural changes to the spec, but I feel it's important to acknowledge/formalize the behaviour it mentions in the actual spec. One such approach could be to make the invite_room_state and similar fields a first-class citizen within the spec, alongside the likes of Room Events and State Events. We'd effectively have a definition for what a Stripped State Event is and use that throughout the spec in reference. A concern with this approach is that it might be taking it a bit too far when some other representation would be more suited.

Do people have ideas on how to practically represent this MSC?

@turt2live turt2live added client-server Client-Server API meta Something that is not a spec change/request and is not related to the build tools labels Sep 24, 2021
@clokep
Copy link
Member

clokep commented Sep 27, 2021

We'd effectively have a definition for what a Stripped State Event is and use that throughout the spec in reference.

This was my thought of how we would represent it, but I don't know if there's a clearer way. I think consolidating all of that together into a single definition would be clearer though!

@richvdh
Copy link
Member

richvdh commented Nov 30, 2021

I have some ideas (indeed, an incomplete matrix-doc branch) around clarifying https://spec.matrix.org/unstable/client-server-api/#types-of-room-events to emphasise that this is the "serialised" form of events which are sent over the C-S api, as opposed to the "raw" events that are sent over federation. (said branch is currently a bit blocked behind #3524). I think it would be a relatively natural home for the definition of a "stripped state event".

One problem with putting it there is that it applies as much to the S-S API as it does the C-S API; still, it's not the only place we have that problem.

@turt2live
Copy link
Member Author

The more we get the individual sections in a position to be airlifted out of the client-server spec the closer we are to making those cross-cutting clarifications to the whole spec, I think. This is a prime opportunity to put new information in a place that is easily cut and pasted out to a different place down the road.

@turt2live
Copy link
Member Author

see #3606

turt2live added a commit that referenced this issue Jan 5, 2022
* Describe and hoist stripped state to a first-class citizen

Fixes #3413
MSC: #3173

* Add changelog

* may->can for clarity

* Update text per review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API meta Something that is not a spec change/request and is not related to the build tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants