New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag ordering is defined as a number between 0 and 1, not strings #1139

Merged
merged 3 commits into from Mar 5, 2018

Conversation

Projects
None yet
2 participants
@turt2live
Member

turt2live commented Mar 3, 2018

Riot, etc all use numbers for ordering.

turt2live added some commits Mar 3, 2018

Tag ordering is defined as a number between 0 and 1, not strings
Signed-off-by: Travis Ralston <travpc@gmail.com>
Add changelog entry for m.tag ordering
Signed-off-by: Travis Ralston <travpc@gmail.com>
@@ -2,7 +2,7 @@
"type": "m.tag",
"content": {
"tags": {
"work": {"order": 1}
"u.work": {"order": 1}

This comment has been minimized.

@turt2live

turt2live Mar 3, 2018

Member

The spec recommends u.work, so I thought I'd throw that in here.

@richvdh richvdh merged commit fd27be8 into matrix-org:master Mar 5, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@turt2live turt2live deleted the turt2live:travis/m.tag branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment