Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag ordering is defined as a number between 0 and 1, not strings #1139

Merged
merged 3 commits into from Mar 5, 2018

Conversation

turt2live
Copy link
Member

Riot, etc all use numbers for ordering.

Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
@@ -2,7 +2,7 @@
"type": "m.tag",
"content": {
"tags": {
"work": {"order": 1}
"u.work": {"order": 1}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec recommends u.work, so I thought I'd throw that in here.

@richvdh richvdh merged commit fd27be8 into matrix-org:master Mar 5, 2018
@turt2live turt2live deleted the travis/m.tag branch March 6, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants