Skip to content

Commit

Permalink
Merge pull request #1139 from turt2live/travis/m.tag
Browse files Browse the repository at this point in the history
Tag ordering is defined as a number between 0 and 1, not strings
  • Loading branch information
richvdh committed Mar 5, 2018
2 parents 66f434c + a0dda3c commit fd27be8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
2 changes: 2 additions & 0 deletions changelogs/client_server.rst
Expand Up @@ -21,6 +21,8 @@ Unreleased changes
(`#1109 <https://github.com/matrix-org/matrix-doc/pull/1109>`_).
- Fix the representation of ``m.presence`` events
(`#1137 <https://github.com/matrix-org/matrix-doc/pull/1137>`_).
- Clarify that ``m.tag`` ordering is done with numbers, not strings
(`#1139 <https://github.com/matrix-org/matrix-doc/pull/1139>`_).

- Changes to the API which will be backwards-compatible for clients:

Expand Down
2 changes: 1 addition & 1 deletion event-schemas/examples/m.tag
Expand Up @@ -2,7 +2,7 @@
"type": "m.tag",
"content": {
"tags": {
"work": {"order": 1}
"u.work": {"order": 1}
}
}
}
11 changes: 5 additions & 6 deletions specification/modules/tags.rst
Expand Up @@ -35,12 +35,11 @@ the tags are for.
Each tag has an associated JSON object with information about the tag, e.g how
to order the rooms with a given tag.

Ordering information is given under the ``order`` key as a string. The string
are compared lexicographically by unicode codepoint to determine which should
displayed first. So a room with a tag with an ``order`` key of ``"apples"``
would appear before a room with a tag with an ``order`` key of ``"oranges"``.
If a room has a tag without an ``order`` key then it should appear after the
rooms with that tag that have an ``order`` key.
Ordering information is given under teh ``order`` key as a number between 0 and
1. The numbers are compared such that 0 is displayed first. Therefore a room
with an ``order`` of ``0.2`` would be displayed before a room with an ``order``
of ``0.7``. If a room has a tag without an ``order`` key then it should appear
after the rooms with that tag that have an ``order`` key.

The name of a tag MUST not exceed 255 bytes.

Expand Down

0 comments on commit fd27be8

Please sign in to comment.