New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace applicable types of 'number' to 'integer' #1571

Merged
merged 3 commits into from Aug 28, 2018

Conversation

3 participants
@turt2live
Member

turt2live commented Aug 27, 2018

Rendered: see 'docs' status check


number implies/represents a float where integer does not.

The only remaining type: number in the project appear on power levels: those have been left untouched pending clarification.

Fixes #746

@turt2live turt2live requested a review from matrix-org/spec-core-team Aug 27, 2018

@turt2live turt2live added this to In review (just the PRs) in August 2018 r0 via automation Aug 27, 2018

Replace applicable types of 'number' to 'integer'
`number` implies/represents a float where `integer` does not.

The only remaining `type: number` in the project appear on power levels: those have been left untouched pending clarification.

Fixes #746

@turt2live turt2live force-pushed the turt2live:travis/general/number-to-int branch from de42921 to 667fa08 Aug 27, 2018

@ara4n

This comment has been minimized.

Member

ara4n commented Aug 28, 2018

lgtm, except we definitely need to spec PLs as integers.

August 2018 r0 automation moved this from In review (just the PRs) to Reviewer approved Aug 28, 2018

@richvdh

LGTM.

If there were any doubt about PLs having to be integers: PLs go in events, which means they must be representable in canonicaljson, which forbids floats.

@turt2live turt2live merged commit 6cdb463 into matrix-org:master Aug 28, 2018

4 checks passed

ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

August 2018 r0 automation moved this from Reviewer approved to Done (this list will be incomplete) Aug 28, 2018

@turt2live turt2live deleted the turt2live:travis/general/number-to-int branch Aug 28, 2018

turt2live added a commit to turt2live/matrix-doc that referenced this pull request Aug 28, 2018

The `rank` in search results is actually a floating point number
This was accidentally changed in matrix-org#1571 and appears to be the only instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment