Replace applicable types of 'number' to 'integer' #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`number` implies/represents a float where `integer` does not. The only remaining `type: number` in the project appear on power levels: those have been left untouched pending clarification. Fixes matrix-org#746
turt2live
force-pushed
the
travis/general/number-to-int
branch
from
de42921
to
667fa08
Compare
|
lgtm, except we definitely need to spec PLs as integers. |
August 2018 r0
automation
moved this from In review (just the PRs)
to Reviewer approved
Aug 28, 2018
richvdh
approved these changes
Aug 28, 2018
August 2018 r0
automation
moved this from Reviewer approved
to Done (this list will be incomplete)
Aug 28, 2018
turt2live
added a commit
to turt2live/matrix-doc
that referenced
this pull request
Aug 28, 2018
This was accidentally changed in matrix-org#1571 and appears to be the only instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered: see 'docs' status check
numberimplies/represents a float whereintegerdoes not.The only remaining
type: numberin the project appear on power levels: those have been left untouched pending clarification.Fixes #746