Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use example.org on examples instead of domain.com which is a real domain #1650

Merged
merged 1 commit into from Sep 2, 2018

Conversation

Projects
3 participants
@mujx
Copy link
Contributor

commented Sep 2, 2018

No description provided.

Use example.org on examples instead of domain.com which is a real domain
Signed-off-by: Konstantinos Sideris <sideris.konstantin@gmail.com>

@mujx mujx requested a review from matrix-org/spec-core-team Sep 2, 2018

@@ -245,7 +245,7 @@ paths:
type: string
description: |-
The third party identifier that received the invite.
example: "alice@domain.com"
example: "alice@example.com"

This comment has been minimized.

Copy link
@mujx

mujx Sep 2, 2018

Author Contributor

example.org was already taken on this example.

@turt2live
Copy link
Member

left a comment

Might not need changes to the drafts, but otherwise looks okay to me

@turt2live turt2live added this to In review (just the PRs) in August 2018 r0 via automation Sep 2, 2018

@turt2live turt2live moved this from In review (just the PRs) to Reviewer approved in August 2018 r0 Sep 2, 2018

@ara4n

This comment has been minimized.

Copy link
Member

commented Sep 2, 2018

lgtm; thanks.

@ara4n ara4n merged commit 8a949af into matrix-org:master Sep 2, 2018

7 checks passed

ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

August 2018 r0 automation moved this from Reviewer approved to Done (this list will be incomplete) Sep 2, 2018

@mujx mujx deleted the mujx:use-example-org branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.