Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use example.org on examples instead of domain.com which is a real domain #1650

Merged
merged 1 commit into from
Sep 2, 2018
Merged

Use example.org on examples instead of domain.com which is a real domain #1650

merged 1 commit into from
Sep 2, 2018

Conversation

mujx
Copy link
Contributor

@mujx mujx commented Sep 2, 2018

No description provided.

Signed-off-by: Konstantinos Sideris <sideris.konstantin@gmail.com>
@mujx mujx requested a review from a team September 2, 2018 14:59
@@ -245,7 +245,7 @@ paths:
type: string
description: |-
The third party identifier that received the invite.
example: "alice@domain.com"
example: "alice@example.com"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example.org was already taken on this example.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not need changes to the drafts, but otherwise looks okay to me

@ara4n
Copy link
Member

ara4n commented Sep 2, 2018

lgtm; thanks.

@ara4n ara4n merged commit 8a949af into matrix-org:master Sep 2, 2018
@mujx mujx deleted the use-example-org branch September 3, 2018 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants