MSC 1915 - Add a 3PID unbind API #1915

erikjohnston · 2019-03-06T11:33:35Z

An alternative proposal to #1194

proposals/1915-unbind-identity-server-param.md

dbkr · 2019-03-07T18:30:22Z

proposals/1915-unbind-identity-server-param.md

+
+### Client-Server API
+
+Add `POST /_matrix/client/r0/account/3pid/delete` API, which expects a JSON body


This API already exists: https://matrix.org/docs/spec/client_server/r0.4.0.html#post-matrix-client-r0-account-3pid-delete (you're just adding the id_server param).

Also, the account deactivate API deletes threepids too and therefore might try to unbind them, so if you have an id_server param on this API it implies there out to be one on there too.

Also also, the API to add threepids has a bind boolean parameter controlling whether the HS should also bind the threepid on the given IS. It could make sense for the delete API to have this param too. On the other hand, does it make sense to delete a 3pid from the server but not want to unbind it from the IS?

Good points.

Also also, the API to add threepids has a bind boolean parameter controlling whether the HS should also bind the threepid on the given IS. It could make sense for the delete API to have this param too. On the other hand, does it make sense to delete a 3pid from the server but not want to unbind it from the IS?

Honestly, I see this as mostly a problem with the APIs and functionality as they stand. I think to fix this we need to have a big rethink of it all.

proposals/1915-unbind-identity-server-param.md

Co-Authored-By: erikjohnston <erikj@jki.re>

proposals/1915-unbind-identity-server-param.md

turt2live

This is realistically my only concern. The proposal looks great overall, and avoiding breaking changes is really appreciated.

proposals/1915-unbind-identity-server-param.md

Co-Authored-By: erikjohnston <erikj@jki.re>

turt2live

Thanks for enduring my feedback

erikjohnston · 2019-03-18T14:09:39Z

@mscbot fcp merge

mscbot · 2019-03-18T14:13:41Z

Team member @erikjohnston has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

mscbot · 2019-03-18T15:15:44Z

🔔 This is now entering its final comment period, as per the review above. 🔔

mscbot · 2019-03-24T04:44:14Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

turt2live · 2019-03-24T04:45:50Z

this now needs an implementation and it's good to go

turt2live · 2019-05-20T18:13:02Z

Implementation happened at matrix-org/synapse#4982 so this now just needs spec

anoadragon453 · 2019-05-21T17:58:20Z

FYI this MSC needs to be updated to reflect that the path should actually be POST /_matrix/identity/api/v1/3pid/unbind. The MSC is missing the /3pid bit.

turt2live · 2019-05-21T18:00:36Z

it was: 2eb9708

anoadragon453 · 2019-05-21T18:01:40Z

Ah ok, cool thanks.

Edit: have updated the link in the OP as people usually click that.

As per [MSC1915](#1915) Implementation proof: matrix-org/synapse#4982 The only alteration made which differs from the proposal is clarity on how to handle homeservers not knowing the `id_server`. All other differences are unintentional.

As per [MSC1915](#1915) Implementation proof: * matrix-org/synapse#4982 * matrix-org/sydent#160 The only alteration made which differs from the proposal is clarity on how to handle homeservers not knowing the `id_server`. All other differences are unintentional.

turt2live · 2019-05-28T21:06:43Z

Spec PR: #2046

turt2live · 2019-06-07T13:34:15Z

merged 🎉

Add a 3PID unbind API

f92925e

erikjohnston requested a review from a team March 6, 2019 11:34

richvdh self-requested a review March 6, 2019 11:57

erikjohnston added proposal A matrix spec change proposal proposal-in-review labels Mar 6, 2019

turt2live self-requested a review March 6, 2019 19:50

turt2live requested changes Mar 6, 2019

View reviewed changes

proposals/1915-unbind-identity-server-param.md Outdated Show resolved Hide resolved

proposals/1915-unbind-identity-server-param.md Outdated Show resolved Hide resolved

Add alternative sid/client_secret authentication

ee6513d

dbkr reviewed Mar 7, 2019

View reviewed changes

neilisfragile assigned erikjohnston Mar 8, 2019

Update proposals/1915-unbind-identity-server-param.md

77110b4

Co-Authored-By: erikjohnston <erikj@jki.re>

richvdh removed their request for review March 11, 2019 18:02

Update wording and add deactivate account API

60f1cf7

erikjohnston requested a review from turt2live March 15, 2019 15:13

uhoreg reviewed Mar 15, 2019

View reviewed changes

proposals/1915-unbind-identity-server-param.md Outdated Show resolved Hide resolved

turt2live requested changes Mar 15, 2019

View reviewed changes

proposals/1915-unbind-identity-server-param.md Outdated Show resolved Hide resolved

Be more explicit identity server selection and errors

bd4fab7

erikjohnston requested a review from turt2live March 18, 2019 09:33

dbkr reviewed Mar 18, 2019

View reviewed changes

proposals/1915-unbind-identity-server-param.md Outdated Show resolved Hide resolved

Update proposals/1915-unbind-identity-server-param.md

410a5db

Co-Authored-By: erikjohnston <erikj@jki.re>

turt2live approved these changes Mar 18, 2019

View reviewed changes

mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Mar 18, 2019

richvdh removed the proposal-in-review label Mar 18, 2019

mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Mar 18, 2019

turt2live mentioned this pull request Mar 18, 2019

A way for HSes to remove bindings from ISes (aka unbind) #1194

Closed

turt2live added the c2s r0.5.0 Part of the r0.5.0 goal (and related releases) label Mar 18, 2019

mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Mar 24, 2019

turt2live merged commit b76b7cd into master Mar 24, 2019

This was referenced Mar 28, 2019

Implement MSC 1915 unbind via sid matrix-org/sydent#134

Closed

Track which ID server was used when binding 3PID matrix-org/synapse#4962

Closed

turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels May 20, 2019

turt2live added this to To add to spec in Matrix 1.0 workflow via automation May 20, 2019

turt2live assigned turt2live and unassigned erikjohnston May 27, 2019

turt2live moved this from To add to spec to In progress in Matrix 1.0 workflow May 28, 2019

turt2live mentioned this pull request May 28, 2019

Spec 3PID unbind API #2046

Merged

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 28, 2019

turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 7, 2019

turt2live moved this from In progress to Done in Matrix 1.0 workflow Jun 7, 2019

turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSC 1915 - Add a 3PID unbind API #1915

MSC 1915 - Add a 3PID unbind API #1915

erikjohnston commented Mar 6, 2019 •

edited by anoadragon453

Loading

dbkr Mar 7, 2019

erikjohnston Mar 12, 2019

turt2live left a comment

turt2live left a comment

erikjohnston commented Mar 18, 2019

mscbot commented Mar 18, 2019 •

edited by richvdh

Loading

mscbot commented Mar 18, 2019

mscbot commented Mar 24, 2019

turt2live commented Mar 24, 2019

turt2live commented May 20, 2019

anoadragon453 commented May 21, 2019

turt2live commented May 21, 2019

anoadragon453 commented May 21, 2019 •

edited

Loading

turt2live commented May 28, 2019

turt2live commented Jun 7, 2019


		### Client-Server API

		Add `POST /_matrix/client/r0/account/3pid/delete` API, which expects a JSON body

MSC 1915 - Add a 3PID unbind API #1915

MSC 1915 - Add a 3PID unbind API #1915

Conversation

erikjohnston commented Mar 6, 2019 • edited by anoadragon453 Loading

dbkr Mar 7, 2019

Choose a reason for hiding this comment

erikjohnston Mar 12, 2019

Choose a reason for hiding this comment

turt2live left a comment

Choose a reason for hiding this comment

turt2live left a comment

Choose a reason for hiding this comment

erikjohnston commented Mar 18, 2019

mscbot commented Mar 18, 2019 • edited by richvdh Loading

mscbot commented Mar 18, 2019

mscbot commented Mar 24, 2019

turt2live commented Mar 24, 2019

turt2live commented May 20, 2019

anoadragon453 commented May 21, 2019

turt2live commented May 21, 2019

anoadragon453 commented May 21, 2019 • edited Loading

turt2live commented May 28, 2019

turt2live commented Jun 7, 2019

erikjohnston commented Mar 6, 2019 •

edited by anoadragon453

Loading

mscbot commented Mar 18, 2019 •

edited by richvdh

Loading

anoadragon453 commented May 21, 2019 •

edited

Loading