Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2153: Add a default push rule to ignore m.reaction events #2153

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@jryans
Copy link
Member

commented Jul 4, 2019

Reactions are considered "metadata" that annotates an existing event and thus they should not by default trigger notifications. This adds a new default override rule that ignores reaction events for the purpose of notifications.

Rendered

@jryans jryans changed the title Add reaction push rule proposal MSC2153: Add reaction push rule proposal Jul 4, 2019

@jryans jryans changed the title MSC2153: Add reaction push rule proposal MSC2153: Add a default push rule to ignore m.reaction events Jul 4, 2019

@anoadragon453
Copy link
Member

left a comment

Looks very plausible.

Show resolved Hide resolved proposals/2153-reaction-push-rule.md Outdated
Fix grammar error
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

jryans added a commit to matrix-org/matrix-js-sdk that referenced this pull request Jul 4, 2019

Add default push rule to ignore reactions
This adds a default push rule to ignore reactions as proposed in
[MSC2153](matrix-org/matrix-doc#2153). By adding it here
in the client directly, we can try out the idea early even if it hasn't appeared
in the user's HS yet.

Part of vector-im/riot-web#10208

@turt2live turt2live self-requested a review Jul 4, 2019

@turt2live
Copy link
Member

left a comment

lgtm

soliciting review from @dbkr as the push rule expert would also be ideal.

@jryans jryans requested a review from dbkr Jul 4, 2019

@dbkr

dbkr approved these changes Jul 5, 2019

@anoadragon453

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Seems like people are generally happy with this one, so:

@mscbot fcp merge

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2019

Team member @anoadragon453 has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

jryans added a commit to matrix-org/synapse that referenced this pull request Jul 5, 2019

Add default push rule to ignore reactions
This adds a default push rule following the proposal in
[MSC2153](matrix-org/matrix-doc#2153).

See also vector-im/riot-web#10208
See also matrix-org/matrix-js-sdk#976
@uhoreg

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Looks reasonable, but as a housekeeping matter:

@mscbot concern should not be merged until MSC1849 is ready

jryans added a commit to matrix-org/synapse that referenced this pull request Jul 5, 2019

Add default push rule to ignore reactions (#5623)
This adds a default push rule following the proposal in
[MSC2153](matrix-org/matrix-doc#2153).

See also vector-im/riot-web#10208
See also matrix-org/matrix-js-sdk#976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.