Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2403: Add "knock" feature #2403

Merged
merged 74 commits into from
Mar 29, 2021
Merged

MSC2403: Add "knock" feature #2403

merged 74 commits into from
Mar 29, 2021

Commits on Jan 9, 2020

  1. add knock proposal

    @Sorunome
    Sorunome committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    501d7ec View commit details
    Browse the repository at this point in the history

  2. move to correct msc number

    @Sorunome
    Sorunome committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    bee4e9e View commit details
    Browse the repository at this point in the history

  3. remove stray heading

    @Sorunome
    Sorunome committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    1ef7c17 View commit details
    Browse the repository at this point in the history

  4. remove question regarding federation api version, as it has to be v2

    @Sorunome
    Sorunome committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    1396498 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. make clear displayname and avatar_url are optional, add status codes

    @Sorunome
    Sorunome committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    f0411a3 View commit details
    Browse the repository at this point in the history

  2. forgot to update one json example

    @Sorunome
    Sorunome committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    776436a View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2020

  1. update with new endpoints

    @Sorunome
    Sorunome committed Jan 19, 2020
    Configuration menu
    Copy the full SHA
    53435d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. address issues

    @Sorunome
    Sorunome committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    5ae462d View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Small grammatical fixes

    @anoadragon453
    anoadragon453 committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    d47cb1f View commit details
    Browse the repository at this point in the history

  2. Reflow text to <79 chars

    @anoadragon453
    anoadragon453 committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    c92752d View commit details
    Browse the repository at this point in the history

  3. Note that spam is a preventable, but real possibility as a result

    @anoadragon453
    anoadragon453 committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    38d6708 View commit details
    Browse the repository at this point in the history

  4. Fix the response format of send_knock 

    This aligns with the current v2 federation endpoints. However, we're still using v1
as a prefix here as it is still the first version of this endpoint.
    @anoadragon453
    anoadragon453 committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    de038f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. small grammar

    @anoadragon453
    anoadragon453 committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    39c2168 View commit details
    Browse the repository at this point in the history

  2. Mention that knock -> ban is possible

    @anoadragon453
    anoadragon453 committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    74a341a View commit details
    Browse the repository at this point in the history

  3. Spell out some possible abuse vectors and how to mitigate them

    @anoadragon453
    anoadragon453 committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    716db4e View commit details
    Browse the repository at this point in the history

  4. knock->knock and rescinding of knocks are not allowed

    @anoadragon453
    anoadragon453 committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    d6d5858 View commit details
    Browse the repository at this point in the history

  5. Switch from Power Levels -> Join Rules

    @anoadragon453
    anoadragon453 committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    1051084 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. Fix typo

    @anoadragon453
    anoadragon453 committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    bc90f1c View commit details
    Browse the repository at this point in the history

  2. Remove remaining traces of [200, {}] response format

    @anoadragon453
    anoadragon453 committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    aad6ff4 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Move client recommendations into its own section 

    Hopefully leading to less duplication in recommendations as well
    @anoadragon453
    anoadragon453 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    f3fc539 View commit details
    Browse the repository at this point in the history

  2. It's possible to fight against spam

    @anoadragon453
    anoadragon453 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    651e73b View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary sentence

    @anoadragon453
    anoadragon453 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    965c47b View commit details
    Browse the repository at this point in the history

  4. Spec how a client is notified of pending knock progress

    @anoadragon453
    anoadragon453 committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    ae8ec66 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Federation knock_room_state and minor cleanup

    @anoadragon453
    anoadragon453 committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    5bfd65c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Indicate that this proposal requires a new room version

    @anoadragon453
    anoadragon453 committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    e93a19f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'soru/knock' of github.com:sorunome/matrix-doc into soru… 

    …/knock

* 'soru/knock' of github.com:sorunome/matrix-doc:
  Federation knock_room_state and minor cleanup
    @anoadragon453
    anoadragon453 committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    c9a7b44 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Update proposals/2403-knock.md 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @anoadragon453 @richvdh
    anoadragon453 and richvdh committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    58cb299 View commit details
    Browse the repository at this point in the history

  2. Remove extraneous text

    @anoadragon453
    anoadragon453 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    703fa07 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'soru/knock' of github.com:sorunome/matrix-doc into soru… 

    …/knock
    @anoadragon453
    anoadragon453 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    61fea58 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Allow users to knock over and over, removing CS complexity

    @anoadragon453
    anoadragon453 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    630f7c4 View commit details
    Browse the repository at this point in the history

  2. Match state events sent to a remote server when inviting a user

    @anoadragon453
    anoadragon453 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    fd9d57b View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Add unstable endpoint replacements

    @anoadragon453
    anoadragon453 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    6e47e86 View commit details
    Browse the repository at this point in the history

  2. Mention unstable prefixes for sync, join_rules and membership events

    @anoadragon453
    anoadragon453 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    340f888 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Go into more depth about membership changes surrounding knocking

    @anoadragon453
    anoadragon453 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    e58e207 View commit details
    Browse the repository at this point in the history

  2. Explicitly state that the hs that received the knock must put in the … 

    …room
    @anoadragon453
    anoadragon453 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    9e5ac04 View commit details
    Browse the repository at this point in the history

  3. Clarify endpoint calls clients and servers need to use to handle knocks

    @anoadragon453
    anoadragon453 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    fd8176b View commit details
    Browse the repository at this point in the history

  4. Remove section duplicated by membership change section

    @anoadragon453
    anoadragon453 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    6b99228 View commit details
    Browse the repository at this point in the history

  5. Fix unstable prefix bullet points

    @anoadragon453
    anoadragon453 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    5097fad View commit details
    Browse the repository at this point in the history

  6. Explicitly state what changes to the auth rules are necessary

    @anoadragon453
    anoadragon453 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    6f7bcb6 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Some clarifications and wording fixes

    @anoadragon453
    anoadragon453 committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    525d1d3 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect assumptions about the sender field of a knock event 

    Got a bit confused with the sender and state_key being different in invite
membership events. In case of a knock, even if the knock event is being
inserted into the room by another homeserver over federation, the sender
of the event is still the knocking user, just like the state_key.
    @anoadragon453
    anoadragon453 committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    a924f5b View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Note that redactions of knocks are not a concern

    @anoadragon453
    anoadragon453 committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    815dae6 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Address Travis and Patrick's feedback

    @anoadragon453
    anoadragon453 committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    6c75b83 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. Disallow invite->knock membership changes

    @anoadragon453
    anoadragon453 committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    7dcff8f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Add join_rules to room chunks returned on a public room dir query

    @anoadragon453
    anoadragon453 committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    42e01b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Foreshadow power level requirements for approval/denial of knock

    @anoadragon453
    anoadragon453 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    e99649c View commit details
    Browse the repository at this point in the history

  2. typo

    @anoadragon453
    anoadragon453 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    51a7778 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Public rooms directory backwards compatibility note

    @anoadragon453
    anoadragon453 committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    6a0d07c View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. typo fix

    @anoadragon453
    anoadragon453 committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    5c620de View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Note clients should try to prevent impersonation attacks during knocking

    @anoadragon453
    anoadragon453 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    d5a2a28 View commit details
    Browse the repository at this point in the history

  2. Make ver a required parameter for make_knock

    @anoadragon453
    anoadragon453 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    8400877 View commit details
    Browse the repository at this point in the history

  3. Add 404 on make_knock if unknown room ID

    @anoadragon453
    anoadragon453 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    337c87b View commit details
    Browse the repository at this point in the history

  4. fix typo 

    Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
    @anoadragon453 @uhoreg
    anoadragon453 and uhoreg committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    04cd6b3 View commit details
    Browse the repository at this point in the history

  5. Note experimental room version ID

    @anoadragon453
    anoadragon453 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    74f3b12 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Switch /send_knock/ from v2 to v1; leave a note as to why

    @anoadragon453
    anoadragon453 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    248a3da View commit details
    Browse the repository at this point in the history

  2. Comment on push rules

    @anoadragon453
    anoadragon453 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    eda6584 View commit details
    Browse the repository at this point in the history

  3. Note that implementations may choose to auto-accept knock-related inv… 

    …ites
    @anoadragon453
    anoadragon453 committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    24f61c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @anoadragon453 @richvdh
    anoadragon453 and richvdh committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e790ad2 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Allow knock->knock transitions

    @anoadragon453
    anoadragon453 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    49a7286 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Link to /join/roomIdOrAlias

    @anoadragon453
    anoadragon453 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    c9f34e8 View commit details
    Browse the repository at this point in the history

  2. Move endpoint extras under endpoint's header

    @anoadragon453
    anoadragon453 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    c575f88 View commit details
    Browse the repository at this point in the history

  3. Ensure we return the room_id after knocking via the CS API

    @anoadragon453
    anoadragon453 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    53ad7e3 View commit details
    Browse the repository at this point in the history

  4. Link to existing spec documentation on the public rooms directory

    @anoadragon453
    anoadragon453 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    09018be View commit details
    Browse the repository at this point in the history

  5. Update alternatives section

    @anoadragon453
    anoadragon453 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    c915b64 View commit details
    Browse the repository at this point in the history

  6. Move API endpoint sections up to the top of the proposal

    @anoadragon453
    anoadragon453 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    6556b95 View commit details
    Browse the repository at this point in the history

  7. Split the 'Membership change to ' section into rejecting/rescinding k… 

    …nocks
    @anoadragon453
    anoadragon453 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    ef840c1 View commit details
    Browse the repository at this point in the history

  8. Remove further traces of old /rooms/roomId/knock CS endpoint

    @anoadragon453
    anoadragon453 committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    8bfef19 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Note that homeservers should pass down invites to the client if they … 

    …fail on autojoin
    @anoadragon453
    anoadragon453 committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    68d2d7c View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Update unstable endpoints from i.e xyz.amorgan/knock -> xyz.amorgan.k… 

    …nock

I'm doing this for two reasons:

1) If I ever wanted to create another knock-related MSC, it would be nice to be able
to give it a different namespace for endpoints, such as xyz.amorgan.knock2/knock. If
we were only using xyz.amorgan as the namespace for endpoints, that restricts that
namespace to only work for one MSC which attempts to use /knock as part of an endpoint.

2) I accidentally made the implementation use xyz.amorgan.knock/knock :)
    @anoadragon453
    anoadragon453 committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    7f0b2d6 View commit details
    Browse the repository at this point in the history

  2. Be consistent about event auth rules

    @anoadragon453
    anoadragon453 committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    a1a40c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. clarify some words

    @anoadragon453
    anoadragon453 committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    11996fb View commit details
    Browse the repository at this point in the history

  2. Add missing 403/404 response codes

    @anoadragon453
    anoadragon453 committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    10267df View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
    @anoadragon453 @KitsuneRal
    anoadragon453 and KitsuneRal committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    9ebfd98 View commit details
    Browse the repository at this point in the history

  4. Make join_rules field of PublicRoomChunk an optional value

    @anoadragon453
    anoadragon453 committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    a8f4ada View commit details
    Browse the repository at this point in the history