MSC2413: Remove client_secret #2413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
force-pushed
the
anoa/no_client_secret
branch
from
b4cb538
to
5f69bf2
Compare
anoadragon453
changed the title
turt2live
reviewed
Mar 5, 2020
| `client_secret` parameter for the sake of old clients, but they should not | ||
| require it. | ||
|
|
||
| ## Security considerations |
There was a problem hiding this comment.
iirc the client_secret is used for a different flow of 3pid binding which involves the client and identity server, skipping the homeserver (only looping it in at the start and end). That flow isn't well documented in the spec at all.
Might be worth checking with the identity server experts on this one.
turt2live
added
the
needs-implementation
Mguiteria
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered