Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2610: Remove m.login.oauth2 User-Interactive Authentication type from the specification #2610

Merged
merged 2 commits into from
Jul 28, 2020
Merged

MSC2610: Remove m.login.oauth2 User-Interactive Authentication type from the specification #2610

merged 2 commits into from
Jul 28, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 5, 2020 •
edited
Loading

@richvdh richvdh added the proposal A matrix spec change proposal label Jun 5, 2020
@richvdh richvdh mentioned this pull request Jun 5, 2020
Merged
@richvdh richvdh requested a review from a team June 5, 2020 09:55
@richvdh richvdh mentioned this pull request Jun 5, 2020
Merged
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Jun 5, 2020
@turt2live turt2live self-requested a review June 5, 2020 13:16
@janrenz
Copy link

janrenz commented Jun 9, 2020 •
edited
Loading

Ist this implemented in Synapse by matrix-org/synapse#7256

@richvdh
Copy link
Member Author

richvdh commented Jun 9, 2020

Ist this implemented in Synapse by matrix-org/synapse#7256

no, that uses m.login.sso

anoadragon453
anoadragon453 approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.

proposals/2610-remove-oauth2-auth-type.md Outdated Show resolved Hide resolved
proposals/2610-remove-oauth2-auth-type.md Outdated Show resolved Hide resolved
@richvdh @anoadragon453
Apply suggestions from code review
ac98241 
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
turt2live
turt2live approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for writing this up!

@richvdh
Copy link
Member Author

richvdh commented Jul 6, 2020

there's no implementation work blocking this, so:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jul 6, 2020 •
edited by anoadragon453
Loading

Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 6, 2020
@ara4n
Copy link
Member

ara4n commented Jul 23, 2020

are we aware of anyone using m.login.oauth2 in the wild who is going to be bitten by this?

@mscbot
Copy link
Collaborator

mscbot commented Jul 23, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 23, 2020
@richvdh
Copy link
Member Author

richvdh commented Jul 23, 2020

are we aware of anyone using m.login.oauth2 in the wild who is going to be bitten by this?

I'm not aware of any implementations of it. Indeed, I don't see how it could be implemented, given the current state of the spec: there simply isn't enough information there.

@mscbot
Copy link
Collaborator

mscbot commented Jul 28, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jul 28, 2020
@turt2live turt2live merged commit a96a014 into master Jul 28, 2020
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period labels Jul 28, 2020
@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jul 28, 2020
@turt2live
Copy link
Member

Merged 🎉

@afranke afranke deleted the rav/proposal/remove-oauth2-auth-type branch September 22, 2021 10:37
@ShadowJonathan ShadowJonathan mentioned this pull request Feb 18, 2022
Closed
@S7evinK S7evinK mentioned this pull request Sep 28, 2023
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@richvdh @janrenz @mscbot @ara4n @turt2live @anoadragon453