Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2663: Errors for dealing with non-existent push rules #2663

Merged
merged 3 commits into from
Jul 29, 2020
Merged

MSC2663: Errors for dealing with non-existent push rules #2663

merged 3 commits into from
Jul 29, 2020

Conversation

reivilibre
Copy link
Contributor

@reivilibre reivilibre commented Jul 3, 2020 •
edited
Loading

Rendered

Signed-off-by: Olivier Wilkinson (reivilibre) olivier@librepush.net

@reivilibre
Start MSC2663 proposal
fee59be 
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@reivilibre
Write MSC2663
90a37cd
@reivilibre reivilibre changed the title MSC2663 placeholder MSC2663: Errors for dealing with inexistent push rules Jul 6, 2020
@reivilibre reivilibre marked this pull request as ready for review July 6, 2020 12:14
@turt2live turt2live added kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal proposal-in-review labels Jul 6, 2020
This was referenced Jul 7, 2020
Closed
Merged
@richvdh
Copy link
Member

richvdh commented Jul 9, 2020

inexistent isn't a word. You might say... it's inexistent.

richvdh
richvdh approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@turt2live turt2live self-requested a review July 9, 2020 17:36
@reivilibre
Copy link
Contributor Author

It's not clear to me that 'inexistent' isn't a word; it features on https://www.wordnik.com/words/inexistent .

However, it's not in the Cambridge dictionary so I suppose I will switch over :).

@reivilibre
inexistent may or may not be a non-existent word
3dd5bc4 
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
@richvdh richvdh changed the title MSC2663: Errors for dealing with inexistent push rules MSC2663: Errors for dealing with non-existent push rules Jul 17, 2020
@richvdh
Copy link
Member

richvdh commented Jul 17, 2020

synapse implementation is matrix-org/synapse#7796

@richvdh
Copy link
Member

richvdh commented Jul 17, 2020

I'm going to propose FCP on this even though the impl hasn't landed yet, because it's pretty trivial

@richvdh
Copy link
Member

richvdh commented Jul 17, 2020

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jul 17, 2020 •
edited by ara4n
Loading

Team member @richvdh has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 17, 2020
turt2live
turt2live approved these changes Jul 20, 2020
View reviewed changes
proposals/2663-errors-nonexistent-push-rules.md
Comment on lines +38 to +40
{
"errcode": "M_NOT_FOUND"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully with a message too when it comes to speccing.

@mscbot
Copy link
Collaborator

mscbot commented Jul 24, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 24, 2020
@mscbot
Copy link
Collaborator

mscbot commented Jul 29, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jul 29, 2020
@turt2live turt2live merged commit 0973e88 into master Jul 29, 2020
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jul 29, 2020
turt2live added a commit that referenced this pull request Sep 30, 2020
@turt2live
Add 404 error responses to push rule endpoints
5e60ff8 
MSC: #2663
@turt2live turt2live mentioned this pull request Sep 30, 2020
Merged
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Sep 30, 2020
@turt2live
Copy link
Member

Spec PR: #2796

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Oct 7, 2020
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live mentioned this pull request Oct 14, 2021
Closed
16 tasks
@S7evinK S7evinK mentioned this pull request Sep 28, 2023
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reivilibre @richvdh @mscbot @turt2live