Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2874: Single SSSS #2874

Merged
merged 4 commits into from Mar 21, 2021
Merged

MSC2874: Single SSSS #2874

merged 4 commits into from Mar 21, 2021

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Nov 23, 2020 •
edited

@uhoreg uhoreg changed the title MSCxxxx: Single SSSS MSC2874: Single SSSS Nov 23, 2020
@uhoreg uhoreg added kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal proposal-in-review labels Nov 23, 2020
@uhoreg uhoreg added the e2e label Dec 31, 2020
richvdh
richvdh approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems generally sensible to me

proposals/2874-single-ssss.md Show resolved Hide resolved
proposals/2874-single-ssss.md Outdated Show resolved Hide resolved
@uhoreg @richvdh
Apply suggestions from code review
d9edb3f 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@uhoreg
Copy link
Member Author

uhoreg commented Feb 11, 2021

Implementation:

@uhoreg
Copy link
Member Author

uhoreg commented Feb 11, 2021

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Feb 11, 2021 •
edited by dbkr

Team member @uhoreg has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. and removed proposal-in-review labels Feb 11, 2021
@uhoreg uhoreg mentioned this pull request Feb 11, 2021
Merged
anoadragon453
anoadragon453 approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sensible to me, though I can't really picture the client asking the user which key to use to unlock their SSSS, unless we were storing something other than messages in there. Maybe that's the point. It's nice that that is left as an option for implementations if they choose to though.

Generally it all seems sensible and backwards compatible.

proposals/2874-single-ssss.md Show resolved Hide resolved
@uhoreg uhoreg added this to Ready for FCP ticks in Spec Core Team Backlog Mar 2, 2021
@mscbot
Copy link
Collaborator

mscbot commented Mar 16, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Mar 16, 2021
@uhoreg uhoreg moved this from Ready for FCP ticks to In FCP in Spec Core Team Backlog Mar 16, 2021
@mscbot
Copy link
Collaborator

mscbot commented Mar 21, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Mar 21, 2021
@erkinalp
Copy link

We need a codename for this, because people will think we are randomly hissing :)

@turt2live turt2live merged commit e0dd138 into matrix-org:master Mar 21, 2021
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Mar 21, 2021
@turt2live turt2live moved this from In FCP to Done to some definition in Spec Core Team Backlog Mar 23, 2021
@uhoreg uhoreg mentioned this pull request Apr 28, 2021
Merged
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Apr 28, 2021
@uhoreg
Copy link
Member Author

uhoreg commented Apr 28, 2021

Merged! 🎉

@uhoreg uhoreg added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Apr 28, 2021
richvdh pushed a commit that referenced this pull request Aug 23, 2021
@turt2live @richvdh
Merge pull request #2874 from uhoreg/single_ssss
050c158 
MSC2874: Single SSSS
richvdh pushed a commit that referenced this pull request Aug 27, 2021
@turt2live @richvdh
Merge pull request #2874 from uhoreg/single_ssss
a064779 
MSC2874: Single SSSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
e2e kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
  
Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@uhoreg @mscbot @erkinalp @anoadragon453 @richvdh @dbkr @turt2live @ara4n @KitsuneRal