Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI: include peekEvents #3336

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

lukaslihotzki
Copy link
Contributor

Disambiguate from getEvents by a trailing space in path (like inviteUser).

Signed-off-by: Lukas Lihotzki lukas@lihotzki.de

@uhoreg uhoreg requested a review from a team August 13, 2021 02:39
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is rendered now (you can click on the “swagger” link in the CI section below), Swagger UI shows two operations (one of them deprecated) with exactly the same summary, which looks a bit confusing. Can you alter the peekEvents summary so that the difference is clearer?

@KitsuneRal
Copy link
Member

Also: changelog entry plz.

Disambiguate from getEvents by a trailing space in path (like inviteUser).

Signed-off-by: Lukas Lihotzki <lukas@lihotzki.de>
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KitsuneRal KitsuneRal merged commit c8b9fe5 into matrix-org:master Aug 17, 2021
richvdh pushed a commit that referenced this pull request Aug 23, 2021
richvdh pushed a commit that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants