Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github_repo.md #245

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Update github_repo.md #245

merged 3 commits into from
Apr 1, 2022

Conversation

HarHarLinks
Copy link
Contributor

@HarHarLinks HarHarLinks commented Mar 26, 2022 •
edited

  • really the first step should be to ensure that the app is installed before you even try to connect it
  • clarify creation time room settings
  • "moderator permissions" isn't really accurate, just default or convention (perhaps even element convention rather than matrix convention?)
  • typos

@Half-Shot Half-Shot self-requested a review March 28, 2022 10:27
@HarHarLinks
Copy link
Contributor Author

See also #260

Half-Shot
Half-Shot approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise good!

docs/usage/room_configuration/github_repo.md Outdated Show resolved Hide resolved
@HarHarLinks @Half-Shot
Clarify github_repo.md
8a14c6c 
Co-authored-by: Will Hunt <will@half-shot.uk>
@HarHarLinks
Copy link
Contributor Author

Otherwise good!

I haven't looked to closely whether there is more in #260 that should be addressed. You should be able to commit to this PR (my forked branch)

@Half-Shot
Copy link
Contributor

I think it's fine to go incremental in these cases :). We can fix #260 in subsequent PRs.

@Half-Shot Half-Shot merged commit 7ce1fd5 into matrix-org:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HarHarLinks @Half-Shot