Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sanitized HTML from feed summaries #738

Merged
merged 13 commits into from
May 18, 2023
Merged

Allow sanitized HTML from feed summaries #738

merged 13 commits into from
May 18, 2023

Conversation

Half-Shot
Copy link
Contributor

Fixes #732

@Half-Shot Half-Shot requested a review from a team as a code owner May 4, 2023 09:20
AndrewFerr
AndrewFerr requested changes May 18, 2023
View reviewed changes
changelog.d/738.bugfix Outdated Show resolved Hide resolved
src/Connections/FeedConnection.ts Outdated Show resolved Hide resolved
src/Connections/FeedConnection.ts Outdated Show resolved Hide resolved
src/Connections/FeedConnection.ts Show resolved Hide resolved
Half-Shot and others added 3 commits May 18, 2023 19:50
@Half-Shot @AndrewFerr
Update src/Connections/FeedConnection.ts
eb6b349 
Co-authored-by: Andrew Ferrazzutti <andrewf@element.io>
@Half-Shot @AndrewFerr
Apply suggestions from code review
84c47bc 
Co-authored-by: Andrew Ferrazzutti <andrewf@element.io>
@Half-Shot
Add a test for partial html
3d1dad5
@Half-Shot Half-Shot requested a review from AndrewFerr May 18, 2023 18:53
@Half-Shot Half-Shot added this pull request to the merge queue May 18, 2023
Merged via the queue into main with commit 466ab6d May 18, 2023
11 checks passed
@Half-Shot Half-Shot deleted the hs/feed-html branch May 18, 2023 19:06
@Mikaela Mikaela mentioned this pull request May 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feed templates: $SUMMARY escapes HTML thus looking unexpected
2 participants
@Half-Shot @AndrewFerr