Show GitHub workflow errors in a thread below failure messages #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
reviewed
May 5, 2023
tadzik
suggested changes
May 24, 2023
| extraThreadContent.html += `<li><strong>${conclusion}</strong> ${step.name} </li>`; | ||
| } | ||
| } | ||
| extraThreadContent.html += `</ul>`; |
There was a problem hiding this comment.
I counted the tags and it looks alright – but I prefer things like this to be done with list-map()-join() combos to not leave any room for errors.
Also, any reason why the HTML is hand-crafted here instead of using an MD renderer like we usually do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #742
Nice and simple. Logs are quite a bit harder but folks should be able to click through to GitHub for that.