Improve request throughput #895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing this showed that the H2 client for |
Half-Shot
force-pushed
the
hs/improve-request-throughput
branch
from
71e845f
to
806810a
Compare
|
Tested again on staging and it seems to work, but holding off until undici release the fix for #2704 |
tadzik
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Looks good to me – but since it relies very heavily on the internals on bot-sdk, I'd consider locking matrix-bot-sdk to the exact version this was developed/tested against, so that a patch release that assumes to do refactoring with no outside changes does not break it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Larger deployments seem to struggle with many requests against the same host (i.e. the homeserver), so this change replaces the existing request function with a
fetch-powered function. This also enables support for HTTP/2 / pipelining so in theory we should go a bit faster than at present.