This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
App extension improvements #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efines and structs of MXKRoomInputToolbarView to MXKTools as a class method to be called from elsewhere
…into mxktools-available-sizes
…into app-extension-improvements
…into app-extension-improvements
giomfo
reviewed
Aug 17, 2017
MatrixKit/Models/MXKAppSettings.m
Outdated
| @@ -26,7 +26,7 @@ | |||
|
|
|||
| static MXKAppSettings *standardAppSettings = nil; | |||
|
|
|||
| static NSString *const kMXAppGroupID = @"group.org.matrix"; | |||
| static NSString *const kMXAppGroupID = @"group.im.vector"; | |||
There was a problem hiding this comment.
Please do not change kMXAppGroupID. Let use group.org.matrix as default to avoid mention vector here
| @@ -357,93 +353,6 @@ - (void)pasteText:(NSString *)text | |||
|
|
|||
| #pragma mark - MXKImageCompressionSize | |||
There was a problem hiding this comment.
Remove this #pragma mark, or maybe move it to MXKTools
MatrixKit/Views/MXKPieChartHUD.h
Outdated
| @@ -0,0 +1,17 @@ | |||
| // | |||
There was a problem hiding this comment.
Set the correct file header:
"/*
Copyright 2017 Aram Sargsyan
[...]
*/"
MatrixKit/Views/MXKPieChartHUD.h
Outdated
|
|
||
| #import <UIKit/UIKit.h> | ||
|
|
||
| @interface MXKPieChartHUD : UIView |
There was a problem hiding this comment.
Please inherit the MXKView class (required to handle UI theme change)
MatrixKit/Views/MXKPieChartHUD.m
Outdated
| @@ -0,0 +1,93 @@ | |||
| // | |||
| // MXKPieChartHUD.m | |||
MatrixKit/Views/MXKPieChartHUD.m
Outdated
| self.clipsToBounds = YES; | ||
| self.layer.cornerRadius = 10.0; | ||
|
|
||
| self.pieChartView.backgroundColor = [UIColor clearColor]; |
There was a problem hiding this comment.
You should override [MXKView customizeViewRendering] method in order to move
the color settings in it.
|
Signed-off-by: Aram Sargsyan aram.sargsyan.1997@gmail.com |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.